[WIP] Fix history.replaceState() not propagating back favicons

components/history/core/browser/history_service.cc

Index: components/history/core/browser/history_service.cc
diff --git a/components/history/core/browser/history_service.cc b/components/history/core/browser/history_service.cc
index a9a332668b71fe57641b946dbba929c4e2460bdc..fa1cc1c059c2e408882cc05c1faa013f22f4863b 100644
--- a/components/history/core/browser/history_service.cc
+++ b/components/history/core/browser/history_service.cc
@@ -377,11 +377,11 @@ void HistoryService::AddPage(const GURL& url,
                              const RedirectList& redirects,
                              ui::PageTransition transition,
                              VisitSource visit_source,
-                             bool did_replace_entry) {
+                             base::Optional<GURL> replaced_entry_url) {
   DCHECK(thread_checker_.CalledOnValidThread());
   AddPage(HistoryAddPageArgs(url, time, context_id, nav_entry_id, referrer,
                              redirects, transition, visit_source,
-                             did_replace_entry, true));
+                             replaced_entry_url, true));

[sky, 2017/06/22 15:26:39]

If you're going to pass around values, shouldn't you use std::move to avoid
unnecessary copying?

 }
 
 void HistoryService::AddPage(const GURL& url,
@@ -389,8 +389,8 @@ void HistoryService::AddPage(const GURL& url,
                              VisitSource visit_source) {
   DCHECK(thread_checker_.CalledOnValidThread());
   AddPage(HistoryAddPageArgs(url, time, nullptr, 0, GURL(), RedirectList(),
-                             ui::PAGE_TRANSITION_LINK, visit_source, false,
-                             true));
+                             ui::PAGE_TRANSITION_LINK, visit_source,
+                             base::nullopt, true));
 }
 
 void HistoryService::AddPage(const HistoryAddPageArgs& add_page_args) {