Implement a skeleton of the Superfish interstitial

components/certificate_reporting/cert_logger.proto

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This protobuffer is intended to store reports from Chrome users of
 // certificate errors. A report will be sent from Chrome when it gets
 // e.g. a certificate for google.com that chains up to a root CA not expected by
 // Chrome for that origin, such as DigiNotar (compromised in July 2011), or
 // other pinning errors such as a blacklisted cert in the chain, or
 // (when opted in) other certificate validation errors like an expired
@@ skipping 10 matching lines @@
 
 package certificate_reporting;
 
 // Protocol types
 
 message CertLoggerInterstitialInfo {
   // The different reasons that an SSL warning interstitial could be shown to
   // a user.
   enum InterstitialReason {
     UNKNOWN_INTERSTITIAL_REASON = 0;
-    // A standard SSL interstitial
+    // A standard SSL interstitial.
     INTERSTITIAL_SSL = 1;
-    // An interstitial alerting the user that they are in a captive portal
+    // An interstitial alerting the user that they are in a captive portal.
     INTERSTITIAL_CAPTIVE_PORTAL = 2;
-    // An interstitial telling the user to update their system clock
+    // An interstitial telling the user to update their system clock.
     INTERSTITIAL_CLOCK = 3;
+    // An interstitial telling the user to remove the Superfish software from
+    // their system.
+    INTERSTITIAL_SUPERFISH = 4;

[meacer, 2017/06/22 22:35:37]

This is no longer needed, right? Or if we want to keep track of it, we can still
set it, but not sure if there is value in doing so.

[estark, 2017/06/22 23:17:48]

I was no longer setting this properly, I fixed that (this also needs a test,
which I'm deferring bc time crunch: crbug.com/735803). But I think it's useful
to have. We won't have e.g. Finch info for this interstitial in cert reports, so
it'll be useful to know definitely which cases we showed the Superfish
interstitial in.

[meacer, 2017/06/22 23:22:02]

SG.

   }
 
   // The type of interstitial that was shown
   optional InterstitialReason interstitial_reason = 1;
   // True if the user clicked through to the offending website
   optional bool user_proceeded = 2;
   // True if the user was shown an option to click through
   optional bool overridable = 3;
   // The time (in usec since the Windows epoch) when the client created the
   // interstitial.
@@ skipping 92 matching lines @@
   optional bool is_issued_by_known_root = 9;
 
   // Information about features that were enabled or disabled for the
   // user that might affect certificate validation.
   optional CertLoggerFeaturesInfo features_info = 10;
 
   // False when the report is attempted to be uploaded for the first time. True
   // in all other uploads.
   optional bool is_retry_upload = 11;
 };