Implement a skeleton of the Superfish interstitial

chrome/browser/ssl/ssl_browser_tests.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <utility>
 
 #include "base/base64.h"
 #include "base/base_switches.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 50 matching lines @@
 #include "components/content_settings/core/browser/host_content_settings_map.h"
 #include "components/network_session_configurator/common/network_switches.h"
 #include "components/network_time/network_time_test_utils.h"
 #include "components/network_time/network_time_tracker.h"
 #include "components/prefs/testing_pref_service.h"
 #include "components/security_interstitials/core/controller_client.h"
 #include "components/security_interstitials/core/metrics_helper.h"
 #include "components/security_state/core/security_state.h"
 #include "components/security_state/core/switches.h"
 #include "components/ssl_errors/error_classification.h"
+#include "components/strings/grit/components_strings.h"
 #include "components/variations/variations_associated_data.h"
 #include "components/variations/variations_switches.h"
 #include "components/web_modal/web_contents_modal_dialog_manager.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/interstitial_page.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_frame_host.h"
@@ skipping 26 matching lines @@
 #include "net/test/cert_test_util.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 #include "net/test/embedded_test_server/request_handler_util.h"
 #include "net/test/spawned_test_server/spawned_test_server.h"
 #include "net/test/test_certificate_data.h"
 #include "net/test/test_data_directory.h"
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_filter.h"
 #include "net/url_request/url_request_job.h"
 #include "net/url_request/url_request_test_util.h"
+#include "ui/base/l10n/l10n_util.h"
 
 #if BUILDFLAG(ENABLE_CAPTIVE_PORTAL_DETECTION)
 #include "chrome/browser/ssl/captive_portal_blocking_page.h"
 #endif
 
 #if defined(USE_NSS_CERTS)
 #include "chrome/browser/net/nss_context.h"
 #include "net/cert/nss_cert_database.h"
 #endif  // defined(USE_NSS_CERTS)
 
@@ skipping 3799 matching lines @@
  protected:
   // SecurityInterstitialIDNTest implementation
   security_interstitials::SecurityInterstitialPage* CreateInterstitial(
       content::WebContents* contents,
       const GURL& request_url) const override {
     net::SSLInfo ssl_info;
     ssl_info.cert =
         net::ImportCertFromFile(net::GetTestCertsDirectory(), "ok_cert.pem");
     return SSLBlockingPage::Create(
         contents, net::ERR_CERT_CONTAINS_ERRORS, ssl_info, request_url, 0,
-        base::Time::NowFromSystemTime(), nullptr,
+        base::Time::NowFromSystemTime(), nullptr, false /* is superfish */,
         base::Callback<void(content::CertificateRequestResultType)>());
   }
 };
 
 // Flaky on mac: https://crbug.com/689846
 #if defined(OS_MACOSX)
 #define MAYBE_SSLBlockingPageDecodesIDN DISABLED_SSLBlockingPageDecodesIDN
 #else
 #define MAYBE_SSLBlockingPageDecodesIDN SSLBlockingPageDecodesIDN
 #endif
@@ skipping 793 matching lines @@
   histograms.ExpectUniqueSample("interstitial.ssl_error_handler.superfish",
                                 true, 1);
 }
 
 // Tests that the Superfish histogram is recorded properly when the Superfish
 // certificate is not present.
 IN_PROC_BROWSER_TEST_F(SuperfishSSLUITest, NoSuperfishRecorded) {
   SetUpCertVerifier(false /* use superfish cert */);
   GURL url(https_server_.GetURL("/ssl/google.html"));
   base::HistogramTester histograms;
   ui_test_utils::NavigateToURL(browser(), url);

[meacer, 2017/06/22 22:35:37]

nit: Inline this while you are at it?

[estark, 2017/06/22 23:17:48]

Done.

   histograms.ExpectUniqueSample("interstitial.ssl_error_handler.superfish",
                                 false, 1);
 }
 
+// Tests that the Superfish interstitial is shown when the Finch feature is
+// enabled and the Superfish certificate is present.
+IN_PROC_BROWSER_TEST_F(SuperfishSSLUITest, SuperfishInterstitial) {
+  base::test::ScopedFeatureList scoped_feature_list;
+  scoped_feature_list.InitFromCommandLine("SuperfishInterstitial",
+                                          std::string());
+  SetUpCertVerifier(true /* use superfish cert */);
+  ui_test_utils::NavigateToURL(browser(),
+                               https_server_.GetURL("/ssl/google.html"));
+  content::WebContents* tab =
+      browser()->tab_strip_model()->GetActiveWebContents();
+  content::WaitForInterstitialAttach(tab);
+  InterstitialPage* interstitial_page = tab->GetInterstitialPage();
+  ASSERT_TRUE(interstitial_page);
+  EXPECT_TRUE(WaitForRenderFrameReady(interstitial_page->GetMainFrame()));
+  EXPECT_EQ(SSLBlockingPage::kTypeForTesting,
+            interstitial_page->GetDelegateForTesting()->GetTypeForTesting());
+
+  // Look for keywords on the page to check that the Superfish interstitial is
+  // showing.
+  std::string expected_title =

[meacer, 2017/06/22 22:35:37]

nit: const

[estark, 2017/06/22 23:17:48]

Done.

+      l10n_util::GetStringUTF8(IDS_SSL_SUPERFISH_HEADING);
+  EXPECT_TRUE(chrome_browser_interstitials::IsInterstitialDisplayingText(

[estark, 2017/06/22 22:01:05]

I spent like an hour trying to rewrite this method and being defeated, before I
remembered that this existed

+      interstitial_page, expected_title));
+}
+
+// Tests that the Superfish interstitial is not shown when the Finch feature is
+// disabled.
+IN_PROC_BROWSER_TEST_F(SuperfishSSLUITest, SuperfishInterstitialDisabled) {
+  base::test::ScopedFeatureList scoped_feature_list;
+  scoped_feature_list.InitFromCommandLine(std::string(),
+                                          "SuperfishInterstitial");
+  SetUpCertVerifier(true /* use superfish cert */);
+  ui_test_utils::NavigateToURL(browser(),
+                               https_server_.GetURL("/ssl/google.html"));
+  content::WebContents* tab =
+      browser()->tab_strip_model()->GetActiveWebContents();
+  content::WaitForInterstitialAttach(tab);
+  InterstitialPage* interstitial_page = tab->GetInterstitialPage();
+  ASSERT_TRUE(interstitial_page);
+  EXPECT_TRUE(WaitForRenderFrameReady(interstitial_page->GetMainFrame()));
+  EXPECT_EQ(SSLBlockingPage::kTypeForTesting,
+            interstitial_page->GetDelegateForTesting()->GetTypeForTesting());
+
+  // Look for keywords on the page to check that the Superfish interstitial is
+  // not showing.
+  std::string expected_title = l10n_util::GetStringUTF8(IDS_SSL_V2_HEADING);

[meacer, 2017/06/22 22:35:37]

const

[estark, 2017/06/22 23:17:48]

Done.

+  EXPECT_TRUE(chrome_browser_interstitials::IsInterstitialDisplayingText(
+      interstitial_page, expected_title));
+}
+
 // TODO(jcampan): more tests to do below.
 
 // Visit a page over https that contains a frame with a redirect.
 
 // XMLHttpRequest insecure content in synchronous mode.
 
 // XMLHttpRequest insecure content in asynchronous mode.
 
 // XMLHttpRequest over bad ssl in synchronous mode.
 
 // XMLHttpRequest over OK ssl in synchronous mode.