third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.h - Issue 2948983002: Low memory page navigation GC for low end devices

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.h

Issue 2948983002: Low memory page navigation GC for low end devices (Closed)

Patch Set: fix Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.h b/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.h

index 3af018d8cb6d5a451c89a5f394c86992a861a0c0..666c4a818842c92c1bdf162399a677afb567a494 100644

--- a/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.h

+++ b/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.h

@@ -74,7 +74,7 @@ class LocalWindowProxy final : public WindowProxy {

bool IsLocal() const override { return true; }

void Initialize() override;

- void DisposeContext(Lifecycle next_status) override;

+ void DisposeContext(Lifecycle next_status, bool reusing_frame) override;

haraken 2017/06/23 04:17:00 Can we introduce an enum?

keishi 2017/06/23 06:25:03 Done.

// Creates a new v8::Context with the window wrapper object as the global

// object (aka the inner global). Note that the window wrapper and its