Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: components/autofill/core/browser/personal_data_manager_unittest.cc

Issue 2948943003: Revert "Experiment to add bank name in autofill ui." (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/personal_data_manager_unittest.cc
diff --git a/components/autofill/core/browser/personal_data_manager_unittest.cc b/components/autofill/core/browser/personal_data_manager_unittest.cc
index 96e3a83134065287186fac9917f4c2c2a384e60d..2a1b23db52fc1c27949428a1859cfb752853c0ec 100644
--- a/components/autofill/core/browser/personal_data_manager_unittest.cc
+++ b/components/autofill/core/browser/personal_data_manager_unittest.cc
@@ -24,7 +24,6 @@
#include "base/strings/utf_string_conversions.h"
#include "base/synchronization/waitable_event.h"
#include "base/test/histogram_tester.h"
-#include "base/test/scoped_feature_list.h"
#include "base/test/simple_test_clock.h"
#include "base/threading/thread_task_runner_handle.h"
#include "base/time/time.h"
@@ -3636,8 +3635,8 @@ TEST_F(PersonalDataManagerTest,
base::RunLoop().Run();
std::vector<Suggestion> suggestions =
- personal_data_->GetCreditCardSuggestions(
- AutofillType(CREDIT_CARD_NUMBER), base::ASCIIToUTF16("12345678"));
+ personal_data_->GetCreditCardSuggestions(AutofillType(CREDIT_CARD_NUMBER),
+ base::ASCIIToUTF16("12345678"));
// There should be no suggestions.
ASSERT_EQ(0U, suggestions.size());
@@ -3924,74 +3923,6 @@ TEST_F(PersonalDataManagerTest,
ASSERT_EQ(3U, suggestions.size());
}
-// Tests that server cards will shown bank name when bank name available and
-// feature flag on.
-TEST_F(PersonalDataManagerTest,
- GetCreditCardSuggestions_ShowBankNameOfServerCards) {
- // Turn on feature flag.
- base::test::ScopedFeatureList scoped_feature_list_;
- scoped_feature_list_.InitAndEnableFeature(kAutofillCreditCardBankNameDisplay);
-
- EnableWalletCardImport();
-
- // Add a local card.
- CreditCard credit_card0("287151C8-6AB1-487C-9095-28E80BE5DA15",
- "https://www.example.com");
- test::SetCreditCardInfo(&credit_card0, "Clyde Barrow",
- "347666888555" /* American Express */, "04", "2999",
- "1");
- credit_card0.set_use_count(3);
- credit_card0.set_use_date(AutofillClock::Now() -
- base::TimeDelta::FromDays(1));
- personal_data_->AddCreditCard(credit_card0);
-
- std::vector<CreditCard> server_cards;
-
- // Add a server card without bank name.
- server_cards.push_back(CreditCard(CreditCard::MASKED_SERVER_CARD, "b459"));
- test::SetCreditCardInfo(&server_cards.back(), "Emmet Dalton", "2110", "12",
- "2999", "1");
- server_cards.back().set_use_count(2);
- server_cards.back().set_use_date(AutofillClock::Now() -
- base::TimeDelta::FromDays(1));
- server_cards.back().SetNetworkForMaskedCard(kVisaCard);
-
- // Add a server card with bank name.
- server_cards.push_back(CreditCard(CreditCard::MASKED_SERVER_CARD, "b460"));
- test::SetCreditCardInfo(&server_cards.back(), "Emmet Dalton", "2111", "12",
- "2999", "1");
- server_cards.back().set_use_count(1);
- server_cards.back().set_use_date(AutofillClock::Now() -
- base::TimeDelta::FromDays(1));
- server_cards.back().SetNetworkForMaskedCard(kVisaCard);
- server_cards.back().set_bank_name("Chase");
-
- test::SetServerCreditCards(autofill_table_, server_cards);
-
- EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged())
- .WillOnce(QuitMainMessageLoop());
- base::RunLoop().Run();
-
- std::vector<Suggestion> suggestions =
- personal_data_->GetCreditCardSuggestions(
- AutofillType(CREDIT_CARD_NUMBER),
- /* field_contents= */ base::string16());
- ASSERT_EQ(3U, suggestions.size());
-
- // Local cards will show network.
- EXPECT_EQ(
- base::UTF8ToUTF16(std::string("Amex") + kUTF8MidlineEllipsis + "8555"),
- suggestions[0].value);
- // Server card without bank name will show network.
- EXPECT_EQ(
- base::UTF8ToUTF16(std::string("Visa") + kUTF8MidlineEllipsis + "2110"),
- suggestions[1].value);
- // Server card with bank name will show bank name.
- EXPECT_EQ(
- base::UTF8ToUTF16(std::string("Chase") + kUTF8MidlineEllipsis + "2111"),
- suggestions[2].value);
-}
-
// Tests that only the full server card is kept when deduping with a local
// duplicate of it.
TEST_F(PersonalDataManagerTest,
« no previous file with comments | « components/autofill/core/browser/personal_data_manager.cc ('k') | components/autofill/core/browser/webdata/autofill_table.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698