media/video/capture/win/video_capture_device_factory_win.cc - Issue 294893006: VideoCaptureDeviceFactory: Change device enumeration to callback + QTKit enumerates in UI thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/video/capture/win/video_capture_device_factory_win.cc

Issue 294893006: VideoCaptureDeviceFactory: Change device enumeration to callback + QTKit enumerates in UI thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: QTKit/AVFoundation Factory create of inexistent device and associated unit tests Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/video/capture/win/video_capture_device_factory_win.cc

diff --git a/media/video/capture/win/video_capture_device_factory_win.cc b/media/video/capture/win/video_capture_device_factory_win.cc

index 0ce8a83c82d8936fb21ac5ec64eb18e71d70528d..920126df09e2558b16048b0081d1669b68205f2e 100644

--- a/media/video/capture/win/video_capture_device_factory_win.cc

+++ b/media/video/capture/win/video_capture_device_factory_win.cc

@@ -387,7 +387,6 @@ VideoCaptureDeviceFactoryWin::VideoCaptureDeviceFactoryWin() {

scoped_ptr<VideoCaptureDevice> VideoCaptureDeviceFactoryWin::Create(

- scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner,

const VideoCaptureDevice::Name& device_name) {

DCHECK(thread_checker_.CalledOnValidThread());

scoped_ptr<VideoCaptureDevice> device;

« media/video/capture/mac/video_capture_device_factory_mac.mm ('K') | « media/video/capture/win/video_capture_device_factory_win.h ('k') | no next file » | no next file with comments »