media/video/capture/mac/video_capture_device_factory_mac_unittest.mm - Issue 294893006: VideoCaptureDeviceFactory: Change device enumeration to callback + QTKit enumerates in UI thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/video/capture/mac/video_capture_device_factory_mac_unittest.mm

Issue 294893006: VideoCaptureDeviceFactory: Change device enumeration to callback + QTKit enumerates in UI thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: QTKit/AVFoundation Factory create of inexistent device and associated unit tests Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/video/capture/mac/video_capture_device_factory_mac.mm ('K') | « media/video/capture/mac/video_capture_device_factory_mac.mm ('k') | media/video/capture/mac/video_capture_device_qtkit_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/video/capture/mac/video_capture_device_factory_mac_unittest.mm

diff --git a/media/video/capture/mac/video_capture_device_factory_mac_unittest.mm b/media/video/capture/mac/video_capture_device_factory_mac_unittest.mm

index 6aa23a940301c911379c45168b4b67391f2693e3..bbc2dfb6b7c5fd63a027e9154db4c0ee3a624436 100644

--- a/media/video/capture/mac/video_capture_device_factory_mac_unittest.mm

+++ b/media/video/capture/mac/video_capture_device_factory_mac_unittest.mm

@@ -3,6 +3,7 @@

// found in the LICENSE file.

#include "base/command_line.h"

+#include "base/message_loop/message_loop_proxy.h"

#include "media/base/media_switches.h"

#import "media/video/capture/mac/avfoundation_glue.h"

#include "media/video/capture/mac/video_capture_device_factory_mac.h"

@@ -23,7 +24,8 @@ TEST_F(VideoCaptureDeviceFactoryMacTest, ListDevicesAVFoundation) {

DVLOG(1) << "AVFoundation not supported, skipping test.";

return;

}

- VideoCaptureDeviceFactoryMac video_capture_device_factory;

+ VideoCaptureDeviceFactoryMac video_capture_device_factory(

+ base::MessageLoopProxy::current());

VideoCaptureDevice::Names names;

video_capture_device_factory.GetDeviceNames(&names);