media/video/capture/android/video_capture_device_factory_android.cc - Issue 294893006: VideoCaptureDeviceFactory: Change device enumeration to callback + QTKit enumerates in UI thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/video/capture/android/video_capture_device_factory_android.cc

Issue 294893006: VideoCaptureDeviceFactory: Change device enumeration to callback + QTKit enumerates in UI thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: QTKit/AVFoundation Factory create of inexistent device and associated unit tests Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « media/video/capture/android/video_capture_device_factory_android.h ('k') | media/video/capture/fake_video_capture_device_factory.h » ('j') | media/video/capture/mac/video_capture_device_factory_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/video/capture/android/video_capture_device_factory_android.cc

diff --git a/media/video/capture/android/video_capture_device_factory_android.cc b/media/video/capture/android/video_capture_device_factory_android.cc

index 3a9b8af4a7b1188540fbfa723ebb0c43cb2e5c8a..99ed4926ad6895eca754752c5232a7fb42893dec 100644

--- a/media/video/capture/android/video_capture_device_factory_android.cc

+++ b/media/video/capture/android/video_capture_device_factory_android.cc

@@ -35,7 +35,6 @@ VideoCaptureDeviceFactoryAndroid::createVideoCaptureAndroid(

}

scoped_ptr<VideoCaptureDevice> VideoCaptureDeviceFactoryAndroid::Create(

- scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner,

const VideoCaptureDevice::Name& device_name) {

DCHECK(thread_checker_.CalledOnValidThread());

int id;