Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: chrome/browser/sync_file_system/remote_file_sync_service.h

Issue 294893005: [SyncFS] Make GetOriginStatusMap asynchronous (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Refactoring Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync_file_system/remote_file_sync_service.h
diff --git a/chrome/browser/sync_file_system/remote_file_sync_service.h b/chrome/browser/sync_file_system/remote_file_sync_service.h
index 8a310548f4c6f122c828809ab80bb3c360d5913d..0dfc7386d5bb80d97fe7a43c04dfc536271dabb9 100644
--- a/chrome/browser/sync_file_system/remote_file_sync_service.h
+++ b/chrome/browser/sync_file_system/remote_file_sync_service.h
@@ -111,17 +111,16 @@ class RemoteFileSyncService {
// For GetOriginStatusMap.
typedef std::map<GURL, std::string> OriginStatusMap;
+ typedef base::Callback<void(const OriginStatusMap&)> StatusMapCallback;
// For GetRemoteVersions.
- typedef base::Callback<void(SyncStatusCode status,
- const std::vector<Version>& versions)>
+ typedef base::Callback<void(SyncStatusCode, const std::vector<Version>&)>
RemoteVersionsCallback;
- typedef base::Callback<void(SyncStatusCode status,
- webkit_blob::ScopedFile downloaded)>
+ typedef base::Callback<void(SyncStatusCode, webkit_blob::ScopedFile)>
tzik 2014/05/21 10:52:33 please keep these parameter names
DownloadVersionCallback;
// For DumpFile.
- typedef base::Callback<void(scoped_ptr<base::ListValue> list)> ListCallback;
+ typedef base::Callback<void(scoped_ptr<base::ListValue>)> ListCallback;
// Creates an initialized RemoteFileSyncService for backend |version|
// for |context|.
@@ -192,7 +191,7 @@ class RemoteFileSyncService {
// Returns all origins along with an arbitrary string description of their
// corresponding sync statuses.
- virtual void GetOriginStatusMap(OriginStatusMap* status_map) = 0;
+ virtual void GetOriginStatusMap(const StatusMapCallback& callback) = 0;
// Returns file metadata for |origin| to call |callback|.
virtual void DumpFiles(const GURL& origin,

Powered by Google App Engine
This is Rietveld 408576698