Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2901)

Unified Diff: chrome/browser/sync_file_system/sync_file_system_service.cc

Issue 294893005: [SyncFS] Make GetOriginStatusMap asynchronous (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: scoped_ptr Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync_file_system/sync_file_system_service.cc
diff --git a/chrome/browser/sync_file_system/sync_file_system_service.cc b/chrome/browser/sync_file_system/sync_file_system_service.cc
index 8fb7b71750986440e968d47b60324e708b6a7e27..2fa49d73a7b7dae424d5ac3325f163e9ee222b34 100644
--- a/chrome/browser/sync_file_system/sync_file_system_service.cc
+++ b/chrome/browser/sync_file_system/sync_file_system_service.cc
@@ -305,12 +305,10 @@ SyncServiceState SyncFileSystemService::GetSyncServiceState() {
}
void SyncFileSystemService::GetExtensionStatusMap(
- std::map<GURL, std::string>* status_map) {
- DCHECK(status_map);
- status_map->clear();
- remote_service_->GetOriginStatusMap(status_map);
- if (v2_remote_service_)
- v2_remote_service_->GetOriginStatusMap(status_map);
+ const ExtensionStatusMapCallback& callback) {
+ remote_service_->GetOriginStatusMap(
+ base::Bind(&SyncFileSystemService::DidGetExtensionStatusMap,
+ AsWeakPtr(), callback));
}
void SyncFileSystemService::DumpFiles(const GURL& origin,
@@ -578,6 +576,31 @@ void SyncFileSystemService::DidDumpV2Database(
callback.Run(*v1list);
}
+void SyncFileSystemService::DidGetExtensionStatusMap(
+ const ExtensionStatusMapCallback& callback,
+ scoped_ptr<RemoteFileSyncService::OriginStatusMap> status_map) {
+ if (!v2_remote_service_) {
+ callback.Run(*status_map);
+ return;
+ }
+
+ v2_remote_service_->GetOriginStatusMap(
+ base::Bind(&SyncFileSystemService::DidGetV2ExtensionStatusMap,
+ AsWeakPtr(),
+ callback,
+ base::Passed(status_map.Pass())));
tzik 2014/05/22 05:14:13 s/status_map.Pass()/&status_map/
peria 2014/05/22 06:11:44 Done.
+}
+
+void SyncFileSystemService::DidGetV2ExtensionStatusMap(
+ const ExtensionStatusMapCallback& callback,
+ scoped_ptr<RemoteFileSyncService::OriginStatusMap> status_map_v1,
+ scoped_ptr<RemoteFileSyncService::OriginStatusMap> status_map_v2) {
+ // Merge |status_map_v2| into |status_map_v1|.
+ status_map_v1->insert(status_map_v2->begin(), status_map_v2->end());
+
+ callback.Run(*status_map_v1);
+}
+
void SyncFileSystemService::SetSyncEnabledForTesting(bool enabled) {
sync_enabled_ = enabled;
remote_service_->SetSyncEnabled(sync_enabled_);

Powered by Google App Engine
This is Rietveld 408576698