chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service.h - Issue 294893005: [SyncFS] Make GetOriginStatusMap asynchronous

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service.h

Issue 294893005: [SyncFS] Make GetOriginStatusMap asynchronous (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: scoped_ptr Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/sync_worker.cc ('k') | chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service.cc » ('j') | chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service.h

diff --git a/chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service.h b/chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service.h

index e12484027bd3603a63c301e1e47b241dec96fbfe..d865b9877a059a102b24fbd15dd6b5f6f1c3a6d2 100644

--- a/chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service.h

+++ b/chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service.h

@@ -101,7 +101,7 @@ class DriveFileSyncService : public RemoteFileSyncService,

virtual LocalChangeProcessor* GetLocalChangeProcessor() OVERRIDE;

virtual bool IsConflicting(const fileapi::FileSystemURL& url) OVERRIDE;

virtual RemoteServiceState GetCurrentState() const OVERRIDE;

- virtual void GetOriginStatusMap(OriginStatusMap* status_map) OVERRIDE;

+ virtual void GetOriginStatusMap(const StatusMapCallback& callback) OVERRIDE;

virtual void DumpFiles(const GURL& origin,

const ListCallback& callback) OVERRIDE;

virtual void DumpDatabase(const ListCallback& callback) OVERRIDE;

@@ -369,7 +369,7 @@ class DriveFileSyncService : public RemoteFileSyncService,

int64 largest_fetched_changestamp_;

- std::map<GURL, std::string> pending_batch_sync_origins_;

+ OriginStatusMap pending_batch_sync_origins_;

tzik 2014/05/22 05:14:13 Could you revert this? This is not a OriginStatusM

peria 2014/05/22 06:11:44 Done.

// Is set to true when there's a fair possibility that we have some

// remote changes that haven't been fetched yet.