Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Unified Diff: ui/accessibility/platform/ax_platform_node_mac.mm

Issue 2948883003: Update AX role mapping for summary to AXButton on Mac (Closed)
Patch Set: Fixed duplicate resources error. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/data/accessibility/html/summary-expected-mac.txt ('k') | ui/strings/ui_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/accessibility/platform/ax_platform_node_mac.mm
diff --git a/ui/accessibility/platform/ax_platform_node_mac.mm b/ui/accessibility/platform/ax_platform_node_mac.mm
index 240240e6180bc11f40e56de4fa36fdafd9e65b81..8f87ab43a6a027e1571a16a0d1e3a839ebf052fd 100644
--- a/ui/accessibility/platform/ax_platform_node_mac.mm
+++ b/ui/accessibility/platform/ax_platform_node_mac.mm
@@ -66,7 +66,11 @@ RoleMap BuildRoleMap() {
{ui::AX_ROLE_DIALOG, NSAccessibilityGroupRole},
{ui::AX_ROLE_DETAILS, NSAccessibilityGroupRole},
{ui::AX_ROLE_DIRECTORY, NSAccessibilityListRole},
- {ui::AX_ROLE_DISCLOSURE_TRIANGLE, NSAccessibilityDisclosureTriangleRole},
+ // If Mac supports AXExpandedChanged event with
+ // NSAccessibilityDisclosureTriangleRole, We should update
+ // AX_ROLE_DISCLOSURE_TRIANGLE mapping to
+ // NSAccessibilityDisclosureTriangleRole. http://crbug.com/558324
+ {ui::AX_ROLE_DISCLOSURE_TRIANGLE, NSAccessibilityButtonRole},
{ui::AX_ROLE_DOCUMENT, NSAccessibilityGroupRole},
{ui::AX_ROLE_EMBEDDED_OBJECT, NSAccessibilityGroupRole},
{ui::AX_ROLE_FIGCAPTION, NSAccessibilityGroupRole},
@@ -510,6 +514,9 @@ - (NSString*)AXRoleDescription {
// instead). Do the same as NSTabView and put "tab" in the description.
return [l10n_util::GetNSStringWithFixup(IDS_ACCNAME_TAB_ROLE_DESCRIPTION)
lowercaseString];
+ case ui::AX_ROLE_DISCLOSURE_TRIANGLE:
+ return [l10n_util::GetNSStringWithFixup(
+ IDS_ACCNAME_DISCLOSURE_TRIANGLE_ROLE_DESCRIPTION) lowercaseString];
default:
break;
}
« no previous file with comments | « content/test/data/accessibility/html/summary-expected-mac.txt ('k') | ui/strings/ui_strings.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698