Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2948843002: Add tests of null-aware constructs in void contexts. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add tests of null-aware constructs in void contexts. Fasta desugares some expressions differently in void contexts, so to be on the safe side, we should test that null-aware invocations and property accesses work in both void and non-void contexts. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/e981c6fdbca496dc82b848b419b4595309491dd5

Patch Set 1 #

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 6 months ago (2017-06-20 19:19:51 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 6 months ago (2017-06-20 19:41:25 UTC) #3
Paul Berry
3 years, 6 months ago (2017-06-20 22:12:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e981c6fdbca496dc82b848b419b4595309491dd5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698