Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: components/os_crypt/key_storage_util_linux_unittest.cc

Issue 2948783002: Create setting that disables password stores (Closed)
Patch Set: nits + tests Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/os_crypt/key_storage_util_linux.cc ('k') | components/os_crypt/os_crypt.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "components/os_crypt/key_storage_util_linux.h"
6 #include "base/files/file_path.h"
7 #include "base/files/file_util.h"
8 #include "base/logging.h"
9 #include "base/macros.h"
10 #include "testing/gtest/include/gtest/gtest.h"
11
12 namespace {
13
14 using namespace os_crypt;
15
16 class KeyStorageUtilLinuxPreferenceTest : public testing::Test {
17 public:
18 KeyStorageUtilLinuxPreferenceTest() = default;
19 ~KeyStorageUtilLinuxPreferenceTest() override = default;
20
21 void SetUp() override {
22 ASSERT_TRUE(base::CreateNewTempDirectory("", &fake_user_data_dir_));
23 }
24
25 void TearDown() override {
26 ASSERT_TRUE(base::DeleteFile(fake_user_data_dir_, true));
27 }
28
29 protected:
30 base::FilePath fake_user_data_dir_;
31
32 private:
33 DISALLOW_COPY_AND_ASSIGN(KeyStorageUtilLinuxPreferenceTest);
34 };
35
36 TEST_F(KeyStorageUtilLinuxPreferenceTest, FirstTimeDefaultsToTrue) {
37 EXPECT_TRUE(GetBackendUse(fake_user_data_dir_));
38 }
39
40 TEST_F(KeyStorageUtilLinuxPreferenceTest, SetToTrue) {
41 EXPECT_TRUE(WriteBackendUse(fake_user_data_dir_, true));
42 EXPECT_TRUE(GetBackendUse(fake_user_data_dir_));
43 }
44
45 TEST_F(KeyStorageUtilLinuxPreferenceTest, SetToFalse) {
46 EXPECT_TRUE(WriteBackendUse(fake_user_data_dir_, false));
47 EXPECT_FALSE(GetBackendUse(fake_user_data_dir_));
48 }
49
50 TEST_F(KeyStorageUtilLinuxPreferenceTest, MultipleWrites) {
51 EXPECT_TRUE(WriteBackendUse(fake_user_data_dir_, false));
52 EXPECT_FALSE(GetBackendUse(fake_user_data_dir_));
53
54 EXPECT_TRUE(WriteBackendUse(fake_user_data_dir_, true));
55 EXPECT_TRUE(GetBackendUse(fake_user_data_dir_));
56
57 EXPECT_TRUE(WriteBackendUse(fake_user_data_dir_, false));
58 EXPECT_FALSE(GetBackendUse(fake_user_data_dir_));
59 }
60
61 class KeyStorageUtilLinuxTest : public testing::Test {
62 public:
63 KeyStorageUtilLinuxTest() = default;
64 ~KeyStorageUtilLinuxTest() override = default;
65
66 void SetUp() override {}
67
68 void TearDown() override {}
69
70 private:
71 DISALLOW_COPY_AND_ASSIGN(KeyStorageUtilLinuxTest);
72 };
73
74 TEST_F(KeyStorageUtilLinuxTest, PasswordStoreFlagOverrides) {
75 SelectedLinuxBackend selected;
76
77 selected = SelectBackend(
78 "basic", true, base::nix::DesktopEnvironment::DESKTOP_ENVIRONMENT_GNOME);
79 EXPECT_EQ(selected, SelectedLinuxBackend::BASIC_TEXT);
80
81 selected =
82 SelectBackend("gnome-libsecret", false,
83 base::nix::DesktopEnvironment::DESKTOP_ENVIRONMENT_KDE4);
84 EXPECT_EQ(selected, SelectedLinuxBackend::GNOME_LIBSECRET);
85
86 selected =
87 SelectBackend("gnome-libsecret", true,
88 base::nix::DesktopEnvironment::DESKTOP_ENVIRONMENT_KDE4);
89 EXPECT_EQ(selected, SelectedLinuxBackend::GNOME_LIBSECRET);
90 }
91
92 TEST_F(KeyStorageUtilLinuxTest, IgnoreBackends) {
93 SelectedLinuxBackend selected;
94
95 selected = SelectBackend(
96 "", true, base::nix::DesktopEnvironment::DESKTOP_ENVIRONMENT_GNOME);
97 EXPECT_EQ(selected, SelectedLinuxBackend::GNOME_ANY);
98
99 selected = SelectBackend(
100 "", false, base::nix::DesktopEnvironment::DESKTOP_ENVIRONMENT_GNOME);
101 EXPECT_EQ(selected, SelectedLinuxBackend::BASIC_TEXT);
102
103 selected = SelectBackend(
104 "", true, base::nix::DesktopEnvironment::DESKTOP_ENVIRONMENT_KDE5);
105 EXPECT_EQ(selected, SelectedLinuxBackend::KWALLET5);
106
107 selected = SelectBackend(
108 "", false, base::nix::DesktopEnvironment::DESKTOP_ENVIRONMENT_KDE5);
109 EXPECT_EQ(selected, SelectedLinuxBackend::BASIC_TEXT);
110 }
111
112 } // namespace os_crypt
OLDNEW
« no previous file with comments | « components/os_crypt/key_storage_util_linux.cc ('k') | components/os_crypt/os_crypt.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698