Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2948773002: Rename "field" -> "accessor" in several type inference methods. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename "field" -> "accessor" in several type inference methods. No functional change. This just adjusts nomenclature to reflect the fact that much of the type inference logic for dealing with fields also applies to getters/setters. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/d0f8a47f33f6463d3b5a6271847779d783076db0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -136 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 11 chunks +28 lines, -27 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/dependency_collector.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart View 15 chunks +88 lines, -86 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 6 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 6 months ago (2017-06-20 13:17:34 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 6 months ago (2017-06-20 15:03:38 UTC) #3
Paul Berry
3 years, 6 months ago (2017-06-20 17:34:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d0f8a47f33f6463d3b5a6271847779d783076db0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698