Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: chrome/test/data/webui/print_preview/native_layer_stub.js

Issue 2948723002: Print Preview: Change print to cr.sendWithPromise (Closed)
Patch Set: Address comments and add close_ param Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/print_preview/native_layer_stub.js
diff --git a/chrome/test/data/webui/print_preview/native_layer_stub.js b/chrome/test/data/webui/print_preview/native_layer_stub.js
index 73ba1244b89b5e788a15ae5d6a690ca3df07c510..23e223ee290476340d88b4fde885a62d231159b4 100644
--- a/chrome/test/data/webui/print_preview/native_layer_stub.js
+++ b/chrome/test/data/webui/print_preview/native_layer_stub.js
@@ -15,6 +15,7 @@ cr.define('print_preview', function() {
'getExtensionPrinters',
'getPrivetPrinters',
'getPrinterCapabilities',
+ 'print',
'setupPrinter'
]);
@@ -24,9 +25,6 @@ cr.define('print_preview', function() {
*/
this.eventTarget_ = new cr.EventTarget();
- /** @private {boolean} Whether the native layer has sent a print message. */
- this.printStarted_ = false;
-
/**
* @private {boolean} Whether the native layer has set the generate draft
* parameter when requesting an updated preview.
@@ -99,6 +97,12 @@ cr.define('print_preview', function() {
return this.localDestinationCapabilities_.get(printerId);
},
+ /** @override */
+ print: function() {
+ this.methodCalled('print');
+ return Promise.resolve();
+ },
+
/** @override */
setupPrinter: function(printerId) {
this.methodCalled('setupPrinter', printerId);
@@ -114,7 +118,6 @@ cr.define('print_preview', function() {
generateDraft, requestId) {
this.generateDraft_ = generateDraft;
},
- startPrint: function () { this.printStarted_ = true; },
startHideDialog: function () {},
/** @return {!cr.EventTarget} The native layer event target. */
@@ -128,9 +131,6 @@ cr.define('print_preview', function() {
/** @return {boolean} Whether a new draft was requested for preview. */
generateDraft: function() { return this.generateDraft_; },
- /** @return {boolean} Whether a print request has been issued. */
- isPrintStarted: function() { return this.printStarted_; },
-
/**
* @param {!print_preview.NativeInitialSettings} settings The settings
* to return as a response to |getInitialSettings|.

Powered by Google App Engine
This is Rietveld 408576698