Print Preview: Change print to cr.sendWithPromise

chrome/test/data/webui/print_preview/native_layer_stub.js

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('print_preview', function() {
   /**
   * Test version of the native layer.
   * @constructor
   * @extends {TestBrowserProxy}
   */
   function NativeLayerStub() {
     TestBrowserProxy.call(this, [
         'getInitialSettings',
         'getPrinters',
         'getExtensionPrinters',
         'getPrivetPrinters',
         'getPrinterCapabilities',
+        'print',
         'setupPrinter'
       ]);
 
     /**
      * @private {!cr.EventTarget} The event target used for dispatching and
      *     receiving events.
      */
     this.eventTarget_ = new cr.EventTarget();
 
-    /** @private {boolean} Whether the native layer has sent a print message. */
-    this.printStarted_ = false;
-
     /**
      * @private {boolean} Whether the native layer has set the generate draft
      *      parameter when requesting an updated preview.
      */
     this.generateDraft_ = false;
 
     /**
      * @private {!print_preview.NativeInitialSettings} The initial settings
      *     to be used for the response to a |getInitialSettings| call.
      */
@@ skipping 53 matching lines @@
       return Promise.resolve(true);
     },
 
     /** @override */
     getPrinterCapabilities: function(printerId) {
       this.methodCalled('getPrinterCapabilities', printerId);
       return this.localDestinationCapabilities_.get(printerId);
     },
 
     /** @override */
+    print: function() {
+      this.methodCalled('print');

[dpapad, 2017/06/23 00:13:57]

Nit (for a potential follow CL): Depending on how thorough are tests are, we
could forward all the parameters passed to print() to methodCalled() as a 2nd
param, and assert that the JS sends the expected params to C++.

[rbpotter, 2017/06/23 00:30:24]

That would be useful, so will add it. The existing test is intended
to verify that the call to print doesn't get blocked somewhere in JS
by logic that checks the preview state, so it does not really care
what most parameters are. However, can add verification that they at
least seem reasonable.

+      return Promise.resolve();
+    },
+
+    /** @override */
     setupPrinter: function(printerId) {
       this.methodCalled('setupPrinter', printerId);
       return this.shouldRejectPrinterSetup_ ?
           Promise.reject(this.setupPrinterResponse_) :
           Promise.resolve(this.setupPrinterResponse_);
     },
 
     /** Stubs for |print_preview.NativeLayer| methods that call C++ handlers. */
     previewReadyForTest: function() {},
 
     startGetPreview: function(destination, printTicketStore, documentInfo,
                               generateDraft, requestId) {
       this.generateDraft_ = generateDraft;
     },
-    startPrint: function () { this.printStarted_ = true; },
     startHideDialog: function () {},
 
     /** @return {!cr.EventTarget} The native layer event target. */
     getEventTarget: function() { return this.eventTarget_; },
 
     /** @param {!cr.EventTarget} eventTarget The event target to use. */
     setEventTarget: function(eventTarget) {
       this.eventTarget_ = eventTarget;
     },
 
     /** @return {boolean} Whether a new draft was requested for preview. */
     generateDraft: function() { return this.generateDraft_; },
 
-    /** @return {boolean} Whether a print request has been issued. */
-    isPrintStarted: function() { return this.printStarted_; },
-
     /**
      * @param {!print_preview.NativeInitialSettings} settings The settings
      *     to return as a response to |getInitialSettings|.
      */
     setInitialSettings: function(settings) {
       this.initialSettings_ = settings;
     },
 
     /**
      * @param {!Array<!print_preview.LocalDestinationInfo>} localDestinations
@@ skipping 23 matching lines @@
     setSetupPrinterResponse: function(reject, response) {
       this.shouldRejectPrinterSetup_ = reject;
       this.setupPrinterResponse_ = response;
     },
   };
 
   return {
     NativeLayerStub: NativeLayerStub,
   };
 });