Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2948693002: Verify that inference ignores setters with function-typed arguments. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, scheglov
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Verify that inference ignores setters with function-typed arguments. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/8bb13b8740f8de0c4de09b8354f4b97e032b02d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -0 lines) Patch
M pkg/front_end/test/fasta/kompile.status View 1 chunk +1 line, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_setter_function_typed.dart View 1 chunk +27 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_setter_function_typed.dart.direct.expect View 1 chunk +23 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_setter_function_typed.dart.outline.expect View 1 chunk +21 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_setter_function_typed.dart.strong.expect View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 6 months ago (2017-06-19 21:49:11 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 6 months ago (2017-06-19 22:07:26 UTC) #3
Paul Berry
3 years, 6 months ago (2017-06-19 22:14:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8bb13b8740f8de0c4de09b8354f4b97e032b02d3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698