Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: chrome/android/webapk/shell_apk/AndroidManifest.xml

Issue 2948653002: Allow localization of WebApk name. (Closed)
Patch Set: Fix another tests. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/webapk/shell_apk/AndroidManifest.xml
diff --git a/chrome/android/webapk/shell_apk/AndroidManifest.xml b/chrome/android/webapk/shell_apk/AndroidManifest.xml
index 44f4572d204d8c3e60b9f3614673e1e43cfc833e..9aa46e7793aa5f7d3290bbf7d176c961ed4affc6 100644
--- a/chrome/android/webapk/shell_apk/AndroidManifest.xml
+++ b/chrome/android/webapk/shell_apk/AndroidManifest.xml
@@ -15,7 +15,7 @@
<application
android:icon="@mipmap/app_icon"
- android:label="{{{short_name}}}"
+ android:label="@string/short_name"
android:allowBackup="false">
<activity android:name="org.chromium.webapk.shell_apk.MainActivity"
android:theme="@android:style/Theme.Translucent.NoTitleBar"
@@ -35,8 +35,6 @@
{{#runtime_host}}<meta-data android:name="org.chromium.webapk.shell_apk.runtimeHost" android:value="{{{runtime_host}}}" />{{/runtime_host}}
{{#runtime_host_application_name}}<meta-data android:name="org.chromium.webapk.shell_apk.runtimeHostApplicationName" android:value="{{{runtime_host_application_name}}}" />{{/runtime_host_application_name}}
<meta-data android:name="org.chromium.webapk.shell_apk.startUrl" android:value="{{{start_url}}}" />
- <meta-data android:name="org.chromium.webapk.shell_apk.name" android:value="{{{name}}}" />
- <meta-data android:name="org.chromium.webapk.shell_apk.shortName" android:value="{{{short_name}}}" />
<meta-data android:name="org.chromium.webapk.shell_apk.scope" android:value="{{{scope_url}}}" />
<meta-data android:name="org.chromium.webapk.shell_apk.displayMode" android:value="{{{display_mode}}}" />
<meta-data android:name="org.chromium.webapk.shell_apk.orientation" android:value="{{{orientation}}}" />

Powered by Google App Engine
This is Rietveld 408576698