Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2948493002: Typedefs and IDL file order between platforms could generated different files. (Closed)

Created:
3 years, 6 months ago by terry
Modified:
3 years, 6 months ago
Reviewers:
vsm, Alan Knight
CC:
reviews_dartlang.org, zra
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Typedefs and IDL file order between platforms could generated different files. TBR=alanknight@google.com,vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/8ab1a87aba13532f12f47be8a22415d4811e58b8

Patch Set 1 #

Patch Set 2 : typedefs and IDL xfile ordering between platforms could generated different files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M tools/dom/scripts/generator.py View 2 chunks +3 lines, -2 lines 0 comments Download
M tools/dom/scripts/idlnode.py View 3 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
terry
3 years, 6 months ago (2017-06-18 18:48:29 UTC) #1
terry
Committed patchset #2 (id:20001) manually as 8ab1a87aba13532f12f47be8a22415d4811e58b8 (presubmit successful).
3 years, 6 months ago (2017-06-18 18:54:41 UTC) #3
Alan Knight
3 years, 6 months ago (2017-06-19 16:51:03 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698