Add ConnectionInfoPopupTest.

Add ConnectionInfoPopupTest.

BUG=733856

[lgarron, 2017-06-16 23:00:40]

jbudorick@: I'm trying to add unit tests for ConnectionInfoPopup because to
catch any future bugs like https://crbug.com/733856

However, I don't know how to set up the right mocks. I get:
org.chromium.chrome.browser.page_info.ConnectionInfoPopupTest.showConnectionInfoPopup
java.lang.NullPointerException
	at
org.robolectric.shadows.ShadowViewConfiguration.setup(ShadowViewConfiguration.java:77)
	at
org.robolectric.shadows.ShadowViewConfiguration.get(ShadowViewConfiguration.java:94)
	at android.view.ViewConfiguration.get(ViewConfiguration.java)
	at android.view.View.__constructor__(View.java:4026)
	at android.view.View.<init>(View.java)
	at android.view.ViewGroup.<init>(ViewGroup.java)
	at android.widget.LinearLayout.<init>(LinearLayout.java)
	at
org.chromium.chrome.browser.page_info.ConnectionInfoPopup.<init>(ConnectionInfoPopup.java:57)
	at
org.chromium.chrome.browser.page_info.ConnectionInfoPopup.show(ConnectionInfoPopup.java:242)
	at
org.chromium.chrome.browser.page_info.ConnectionInfoPopupTest.showConnectionInfoPopup(ConnectionInfoPopupTest.java:36)


Do you know where I can look to learn how to set up unit tests for a class like
this?

Thanks,
»Lucas

[jbudorick, 2017-06-19 15:35:08]

On 2017/06/16 23:00:40, lgarron wrote:
> jbudorick@: I'm trying to add unit tests for ConnectionInfoPopup because to
> catch any future bugs like https://crbug.com/733856
> 
> However, I don't know how to set up the right mocks. I get:
>
org.chromium.chrome.browser.page_info.ConnectionInfoPopupTest.showConnectionInfoPopup
> java.lang.NullPointerException
> 	at
>
org.robolectric.shadows.ShadowViewConfiguration.setup(ShadowViewConfiguration.java:77)
> 	at
>
org.robolectric.shadows.ShadowViewConfiguration.get(ShadowViewConfiguration.java:94)
> 	at android.view.ViewConfiguration.get(ViewConfiguration.java)
> 	at android.view.View.__constructor__(View.java:4026)
> 	at android.view.View.<init>(View.java)
> 	at android.view.ViewGroup.<init>(ViewGroup.java)
> 	at android.widget.LinearLayout.<init>(LinearLayout.java)
> 	at
>
org.chromium.chrome.browser.page_info.ConnectionInfoPopup.<init>(ConnectionInfoPopup.java:57)
> 	at
>
org.chromium.chrome.browser.page_info.ConnectionInfoPopup.show(ConnectionInfoPopup.java:242)
> 	at
>
org.chromium.chrome.browser.page_info.ConnectionInfoPopupTest.showConnectionInfoPopup(ConnectionInfoPopupTest.java:36)
> 
> 
> Do you know where I can look to learn how to set up unit tests for a class
like
> this?
> 
> Thanks,
> »Lucas

I know you mentioned resolving this to some extent in our chat offline, though I
forget which part & the message history has evaporated.

In case you didn't already find it, I think something like
https://codesearch.chromium.org/chromium/src/chrome/android/junit/src/org/chr...
would work here.

[lgarron, 2017-06-30 04:51:09]

On 2017/06/19 at 15:35:08, jbudorick wrote:
> On 2017/06/16 23:00:40, lgarron wrote:
> > jbudorick@: I'm trying to add unit tests for ConnectionInfoPopup because to
> > catch any future bugs like https://crbug.com/733856
> > 
> > However, I don't know how to set up the right mocks. I get:
> >
org.chromium.chrome.browser.page_info.ConnectionInfoPopupTest.showConnectionInfoPopup
> > java.lang.NullPointerException
> > 	at
> >
org.robolectric.shadows.ShadowViewConfiguration.setup(ShadowViewConfiguration.java:77)
> > 	at
> >
org.robolectric.shadows.ShadowViewConfiguration.get(ShadowViewConfiguration.java:94)
> > 	at android.view.ViewConfiguration.get(ViewConfiguration.java)
> > 	at android.view.View.__constructor__(View.java:4026)
> > 	at android.view.View.<init>(View.java)
> > 	at android.view.ViewGroup.<init>(ViewGroup.java)
> > 	at android.widget.LinearLayout.<init>(LinearLayout.java)
> > 	at
> >
org.chromium.chrome.browser.page_info.ConnectionInfoPopup.<init>(ConnectionInfoPopup.java:57)
> > 	at
> >
org.chromium.chrome.browser.page_info.ConnectionInfoPopup.show(ConnectionInfoPopup.java:242)
> > 	at
> >
org.chromium.chrome.browser.page_info.ConnectionInfoPopupTest.showConnectionInfoPopup(ConnectionInfoPopupTest.java:36)
> > 
> > 
> > Do you know where I can look to learn how to set up unit tests for a class
like
> > this?
> > 
> > Thanks,
> > »Lucas
> 
> I know you mentioned resolving this to some extent in our chat offline, though
I forget which part & the message history has evaporated.
> 
> In case you didn't already find it, I think something like
https://codesearch.chromium.org/chromium/src/chrome/android/junit/src/org/chr...
would work here.

Closing in favor of https://chromium-review.googlesource.com/c/557428/

[lgarron, 2017-06-30 05:10:37]

In favor of https://chromium-review.googlesource.com/c/557450/ , that is.