Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2948393002: Clean up type parameters in comments (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 6 months ago
Reviewers:
devoncarew
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -357 lines) Patch
M pkg/analyzer/lib/dart/ast/ast.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/dart/ast/ast_factory.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/dart/element/element.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/cancelable_future.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/context/cache.dart View 4 chunks +4 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 4 chunks +5 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/ast.dart View 112 chunks +115 lines, -207 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/ast_factory.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/utilities.dart View 2 chunks +11 lines, -11 lines 0 comments Download
M pkg/analyzer/lib/src/dart/constant/evaluation.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 24 chunks +25 lines, -38 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/handle.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/member.dart View 9 chunks +14 lines, -21 lines 0 comments Download
M pkg/analyzer/lib/src/generated/declaration_resolver.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element_resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 3 chunks +3 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/type_system.dart View 6 chunks +9 lines, -11 lines 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_general.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/dart/ast/ast_test.dart View 16 chunks +18 lines, -18 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 3 chunks +3 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
This doesn't touch kernel or fasta related code, nor does it clean up the old ...
3 years, 6 months ago (2017-06-23 14:56:24 UTC) #2
devoncarew
lgtm
3 years, 6 months ago (2017-06-23 19:52:16 UTC) #3
devoncarew
lgtm lgtm
3 years, 6 months ago (2017-06-23 19:52:18 UTC) #4
Brian Wilkerson
3 years, 6 months ago (2017-06-23 19:53:18 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
4fab4a1f525cf6f6de5abe38f3b50fe82d98e6bb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698