Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: third_party/WebKit/Source/core/core.gni

Issue 2948363004: Fix remove_webcore_debug_symbols to avoid constant building (Closed)
Patch Set: Reduce duplication Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/config.gni ('k') | third_party/WebKit/Source/modules/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chrome_build.gni") 5 import("//build/config/chrome_build.gni")
6 import("//build/split_static_library.gni") 6 import("//build/split_static_library.gni")
7 import("//third_party/WebKit/Source/config.gni") 7 import("//third_party/WebKit/Source/config.gni")
8 8
9 blink_core_output_dir = "$root_gen_dir/blink/core" 9 blink_core_output_dir = "$root_gen_dir/blink/core"
10 10
(...skipping 13 matching lines...) Expand all
24 # build optimize_max config applies this optimization on all platforms, so 24 # build optimize_max config applies this optimization on all platforms, so
25 # compute how to modify the config list to duplicate the GYP behavior. 25 # compute how to modify the config list to duplicate the GYP behavior.
26 # TODO revisit this behavior, as the Windows-specific part seems suspicious. 26 # TODO revisit this behavior, as the Windows-specific part seems suspicious.
27 if (is_win && is_official_build) { 27 if (is_win && is_official_build) {
28 core_config_remove += [ "//build/config/compiler:default_optimization" ] 28 core_config_remove += [ "//build/config/compiler:default_optimization" ]
29 core_config_add += [ "//build/config/compiler:optimize_max" ] 29 core_config_add += [ "//build/config/compiler:optimize_max" ]
30 } 30 }
31 31
32 if (remove_webcore_debug_symbols) { 32 if (remove_webcore_debug_symbols) {
33 core_config_remove += [ "//build/config/compiler:default_symbols" ] 33 core_config_remove += [ "//build/config/compiler:default_symbols" ]
34 core_config_add += [ "//build/config/compiler:no_symbols" ] 34 core_config_add += remove_webcore_symbols_config
35 } 35 }
36 36
37 # Use this target type to link core targets. 37 # Use this target type to link core targets.
38 if (is_component_build) { 38 if (is_component_build) {
39 # To get exported symbols correct in component builds, the files must be in 39 # To get exported symbols correct in component builds, the files must be in
40 # source sets. 40 # source sets.
41 core_link_large_target_type = "source_set" 41 core_link_large_target_type = "source_set"
42 core_link_small_target_type = "source_set" 42 core_link_small_target_type = "source_set"
43 } else { 43 } else {
44 # In static builds some of the libraries can get >2GB on Windows so we need 44 # In static builds some of the libraries can get >2GB on Windows so we need
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 set_defaults("blink_core_sources") { 120 set_defaults("blink_core_sources") {
121 # This sets the default list of configs when the blink_core_sources target 121 # This sets the default list of configs when the blink_core_sources target
122 # is defined. The default_compiler_configs comes from BUILDCONFIG.gn and 122 # is defined. The default_compiler_configs comes from BUILDCONFIG.gn and
123 # is the list normally applied to static libraries and source sets. 123 # is the list normally applied to static libraries and source sets.
124 configs = default_compiler_configs - core_config_remove + core_config_add 124 configs = default_compiler_configs - core_config_remove + core_config_add
125 125
126 # Compile each of the core sources targets with (core) precompiled header 126 # Compile each of the core sources targets with (core) precompiled header
127 # support, for lower Windows build times. 127 # support, for lower Windows build times.
128 configs += [ "//third_party/WebKit/Source/core:blink_core_pch" ] 128 configs += [ "//third_party/WebKit/Source/core:blink_core_pch" ]
129 } 129 }
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/config.gni ('k') | third_party/WebKit/Source/modules/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698