Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: mojo/shell/out_of_process_dynamic_service_runner.cc

Issue 294833002: Mojo: more idiomatic C++ bindings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/shell/out_of_process_dynamic_service_runner.cc
diff --git a/mojo/shell/out_of_process_dynamic_service_runner.cc b/mojo/shell/out_of_process_dynamic_service_runner.cc
index e75ba74e3edc8bb0b53e0255c7b6058753b52efc..39e12885620c0b68cbc8654db2ca920dce6b02de 100644
--- a/mojo/shell/out_of_process_dynamic_service_runner.cc
+++ b/mojo/shell/out_of_process_dynamic_service_runner.cc
@@ -9,7 +9,6 @@
#include "base/file_util.h"
#include "base/logging.h"
#include "base/scoped_native_library.h"
-#include "mojo/public/cpp/bindings/allocation_scope.h"
namespace mojo {
namespace shell {
@@ -44,11 +43,9 @@ void OutOfProcessDynamicServiceRunner::Start(
app_child_process_host_.reset(new AppChildProcessHost(context_, this));
app_child_process_host_->Start();
- // TODO(vtl): Where should my allocation scope be?
- AllocationScope scope;
// TODO(vtl): |app_path.AsUTF8Unsafe()| is unsafe.
app_child_process_host_->controller()->StartApp(
- app_path.AsUTF8Unsafe(),
+ String::From(app_path.AsUTF8Unsafe()),
ScopedMessagePipeHandle(MessagePipeHandle(
service_handle.release().value())));
}

Powered by Google App Engine
This is Rietveld 408576698