Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1325)

Unified Diff: mojo/shell/app_child_process.cc

Issue 294833002: Mojo: more idiomatic C++ bindings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/shell/app_child_process.cc
diff --git a/mojo/shell/app_child_process.cc b/mojo/shell/app_child_process.cc
index 099cfb2ee07d289a69d7859fcc6f1d3b6724aecf..5ef7eb1235ee30a22fd4f58bb44e5e51c32dc2ae 100644
--- a/mojo/shell/app_child_process.cc
+++ b/mojo/shell/app_child_process.cc
@@ -193,16 +193,13 @@ class AppChildControllerImpl : public InterfaceImpl<AppChildController> {
}
// |AppChildController| methods:
- virtual void StartApp(const String& app_path,
+ virtual void StartApp(String app_path,
ScopedMessagePipeHandle service) OVERRIDE {
- DVLOG(2) << "AppChildControllerImpl::StartApp("
- << app_path.To<std::string>() << ", ...)";
+ DVLOG(2) << "AppChildControllerImpl::StartApp(" << app_path << ", ...)";
DCHECK(thread_checker_.CalledOnValidThread());
- // TODO(darin): Add TypeConverter for FilePath <-> mojo::String.
unblocker_.Unblock(base::Bind(&AppChildControllerImpl::StartAppOnMainThread,
- base::FilePath::FromUTF8Unsafe(
- app_path.To<std::string>()),
+ base::FilePath::FromUTF8Unsafe(app_path),
base::Passed(&service)));
}

Powered by Google App Engine
This is Rietveld 408576698