Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: mojo/services/view_manager/type_converters.cc

Issue 294833002: Mojo: more idiomatic C++ bindings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/view_manager/type_converters.cc
diff --git a/mojo/services/view_manager/type_converters.cc b/mojo/services/view_manager/type_converters.cc
index 8f4c98c21794d495dbf524463ba44192568fd759..5808dcf41968a087fd743562e89fa895cbfd27fc 100644
--- a/mojo/services/view_manager/type_converters.cc
+++ b/mojo/services/view_manager/type_converters.cc
@@ -4,13 +4,13 @@
#include "mojo/services/view_manager/type_converters.h"
-#include "mojo/public/cpp/bindings/buffer.h"
#include "mojo/services/public/interfaces/view_manager/view_manager.mojom.h"
#include "mojo/services/view_manager/ids.h"
#include "mojo/services/view_manager/node.h"
#include "mojo/services/view_manager/view.h"
using mojo::view_manager::INode;
+using mojo::view_manager::INodePtr;
using mojo::view_manager::service::Node;
using mojo::view_manager::service::NodeId;
using mojo::view_manager::service::ViewId;
@@ -18,17 +18,16 @@ using mojo::view_manager::service::ViewId;
namespace mojo {
// static
-INode TypeConverter<INode, const Node*>::ConvertFrom(const Node* node,
- Buffer* buf) {
+INodePtr TypeConverter<INodePtr, const Node*>::ConvertFrom(const Node* node) {
DCHECK(node);
- INode::Builder builder(buf);
+ INodePtr result(INode::New());
const Node* parent = node->GetParent();
- builder.set_parent_id(NodeIdToTransportId(parent ? parent->id() : NodeId()));
- builder.set_node_id(NodeIdToTransportId(node->id()));
- builder.set_view_id(ViewIdToTransportId(
- node->view() ? node->view()->id() : ViewId()));
- return builder.Finish();
+ result->parent_id = NodeIdToTransportId(parent ? parent->id() : NodeId());
+ result->node_id = NodeIdToTransportId(node->id());
+ result->view_id = ViewIdToTransportId(
+ node->view() ? node->view()->id() : ViewId());
+ return result.Pass();
}
} // namespace mojo

Powered by Google App Engine
This is Rietveld 408576698