Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1102)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: mojo/services/gles2/command_buffer_impl.cc

Issue 294833002: Mojo: more idiomatic C++ bindings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: improvements per review feedback Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« mojo/public/cpp/bindings/type_converter.h ('K') | « mojo/services/dbus_echo/dbus_echo_service.cc ('k') | mojo/services/gles2/command_buffer_type_conversions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/gles2/command_buffer_impl.cc
diff --git a/mojo/services/gles2/command_buffer_impl.cc b/mojo/services/gles2/command_buffer_impl.cc
index dd5464283f6538c8a52b8049fc0da21c2379cc5a..090b78c370709a9d0f2ff2b0237f92d472da2e36 100644
--- a/mojo/services/gles2/command_buffer_impl.cc
+++ b/mojo/services/gles2/command_buffer_impl.cc
@@ -16,7 +16,6 @@
#include "gpu/command_buffer/service/image_manager.h"
#include "gpu/command_buffer/service/mailbox_manager.h"
#include "gpu/command_buffer/service/memory_tracking.h"
-#include "mojo/public/cpp/bindings/allocation_scope.h"
#include "mojo/services/gles2/command_buffer_type_conversions.h"
#include "mojo/services/gles2/mojo_buffer_backing.h"
#include "ui/gl/gl_context.h"
@@ -152,8 +151,8 @@ void CommandBufferImpl::Flush(int32_t put_offset) {
void CommandBufferImpl::MakeProgress(int32_t last_get_offset) {
// TODO(piman): handle out-of-order.
- AllocationScope scope;
- sync_client_->DidMakeProgress(command_buffer_->GetLastState());
+ sync_client_->DidMakeProgress(
+ CommandBufferState::From(command_buffer_->GetLastState()));
}
void CommandBufferImpl::RegisterTransferBuffer(
« mojo/public/cpp/bindings/type_converter.h ('K') | « mojo/services/dbus_echo/dbus_echo_service.cc ('k') | mojo/services/gles2/command_buffer_type_conversions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698