mojo/services/dbus_echo/dbus_echo_service.cc - Issue 294833002: Mojo: more idiomatic C++ bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/dbus_echo/dbus_echo_service.cc

Issue 294833002: Mojo: more idiomatic C++ bindings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: improvements per review feedback Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/dbus_echo/dbus_echo_service.cc

diff --git a/mojo/services/dbus_echo/dbus_echo_service.cc b/mojo/services/dbus_echo/dbus_echo_service.cc

index bc063b2eb0e6574bbdcf0f286a8ab1efdbada3e7..560daa6b9de9a7d3c5852e05d11a904a3b57b18a 100644

--- a/mojo/services/dbus_echo/dbus_echo_service.cc

+++ b/mojo/services/dbus_echo/dbus_echo_service.cc

@@ -25,7 +25,7 @@ class EchoServiceImpl : public mojo::InterfaceImpl<mojo::EchoService> {

virtual void Echo(

const mojo::String& in_to_echo,

const mojo::Callback<void(mojo::String)>& callback) OVERRIDE {

- DVLOG(1) << "Asked to echo " << in_to_echo.To<std::string>();

+ DVLOG(1) << "Asked to echo " << in_to_echo;

callback.Run(in_to_echo);

}

};