mojo/public/tools/bindings/mojom.gni - Issue 294833002: Mojo: more idiomatic C++ bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/mojom.gni

Issue 294833002: Mojo: more idiomatic C++ bindings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: improvements per review feedback Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/tools/bindings/mojom.gni

diff --git a/mojo/public/tools/bindings/mojom.gni b/mojo/public/tools/bindings/mojom.gni

index d0c6281b477a2200cdcf032aa5b22a18c903a204..308a878a1c72e4fc88cdc7626def07512f368c91 100644

--- a/mojo/public/tools/bindings/mojom.gni

+++ b/mojo/public/tools/bindings/mojom.gni

@@ -12,7 +12,6 @@ template("mojom") {

generator_sources = [

generator_script,

"$generator_root/generators/cpp_templates/enum_declaration.tmpl",

- "$generator_root/generators/cpp_templates/enum_traits.tmpl",

"$generator_root/generators/cpp_templates/interface_declaration.tmpl",

"$generator_root/generators/cpp_templates/interface_definition.tmpl",

"$generator_root/generators/cpp_templates/interface_macros.tmpl",

@@ -24,12 +23,13 @@ template("mojom") {

"$generator_root/generators/cpp_templates/module.h.tmpl",

"$generator_root/generators/cpp_templates/module-internal.h.tmpl",

"$generator_root/generators/cpp_templates/params_definition.tmpl",

- "$generator_root/generators/cpp_templates/struct_builder_definition.tmpl",

"$generator_root/generators/cpp_templates/struct_declaration.tmpl",

"$generator_root/generators/cpp_templates/struct_definition.tmpl",

- "$generator_root/generators/cpp_templates/struct_destructor.tmpl",

+ "$generator_root/generators/cpp_templates/struct_serialization_declaration.tmpl",

+ "$generator_root/generators/cpp_templates/struct_serialization_definition.tmpl",

"$generator_root/generators/cpp_templates/struct_macros.tmpl",

"$generator_root/generators/cpp_templates/wrapper_class_declaration.tmpl",

+ "$generator_root/generators/cpp_templates/wrapper_class_definition.tmpl",

"$generator_root/generators/js_templates/enum_definition.tmpl",

"$generator_root/generators/js_templates/interface_definition.tmpl",

"$generator_root/generators/js_templates/module.js.tmpl",