Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1133)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: mojo/public/cpp/shell/connect.h

Issue 294833002: Mojo: more idiomatic C++ bindings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: improvements per review feedback Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« mojo/public/cpp/bindings/type_converter.h ('K') | « mojo/public/cpp/environment/lib/environment.cc ('k') | mojo/public/cpp/shell/lib/application.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/shell/connect.h
diff --git a/mojo/public/cpp/shell/connect.h b/mojo/public/cpp/shell/connect.h
index caee5897eddd6f4717c3be1381fac0494b6829cd..77e9dcbe32dcfd21f87278d3d7b911b9fd365c9c 100644
--- a/mojo/public/cpp/shell/connect.h
+++ b/mojo/public/cpp/shell/connect.h
@@ -5,7 +5,6 @@
#ifndef MOJO_PUBLIC_CPP_SHELL_CONNECT_H_
#define MOJO_PUBLIC_CPP_SHELL_CONNECT_H_
-#include "mojo/public/cpp/bindings/allocation_scope.h"
#include "mojo/public/interfaces/shell/shell.mojom.h"
namespace mojo {
@@ -16,8 +15,7 @@ inline void ConnectTo(Shell* shell, const std::string& url,
MessagePipe pipe;
ptr->Bind(pipe.handle0.Pass());
- AllocationScope scope;
- shell->Connect(url, pipe.handle1.Pass());
+ shell->Connect(String::From(url), pipe.handle1.Pass());
}
} // namespace mojo
« mojo/public/cpp/bindings/type_converter.h ('K') | « mojo/public/cpp/environment/lib/environment.cc ('k') | mojo/public/cpp/shell/lib/application.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698