mojo/public/cpp/bindings/lib/fixed_buffer.cc - Issue 294833002: Mojo: more idiomatic C++ bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/lib/fixed_buffer.cc

Issue 294833002: Mojo: more idiomatic C++ bindings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: improvements per review feedback Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/cpp/bindings/lib/fixed_buffer.cc

diff --git a/mojo/public/cpp/bindings/lib/fixed_buffer.cc b/mojo/public/cpp/bindings/lib/fixed_buffer.cc

index 53967eb43d91e50dd3a1e3faafa154fca6913311..5226231725c53392bfe20459783299903200f821 100644

--- a/mojo/public/cpp/bindings/lib/fixed_buffer.cc

+++ b/mojo/public/cpp/bindings/lib/fixed_buffer.cc

@@ -27,9 +27,7 @@ FixedBuffer::~FixedBuffer() {

free(ptr_);

}

-void* FixedBuffer::Allocate(size_t delta, Destructor dtor) {

- assert(!dtor);

+void* FixedBuffer::Allocate(size_t delta) {

delta = internal::Align(delta);

if (delta == 0 || delta > size_ - cursor_) {