Mojo: more idiomatic C++ bindings

mojo/services/native_viewport/native_viewport_service.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/services/native_viewport/native_viewport_service.h"
 
 #include "base/macros.h"
 #include "base/message_loop/message_loop.h"
 #include "base/time/time.h"
 #include "mojo/geometry/geometry_type_converters.h"
-#include "mojo/public/cpp/bindings/allocation_scope.h"
 #include "mojo/public/interfaces/shell/shell.mojom.h"
 #include "mojo/services/gles2/command_buffer_impl.h"
 #include "mojo/services/native_viewport/native_viewport.h"
 #include "mojo/services/native_viewport/native_viewport.mojom.h"
 #include "ui/events/event.h"
 
 namespace mojo {
 namespace services {
 namespace {
 
@@ skipping 12 matching lines @@
   NativeViewportImpl(shell::Context* context)
       : context_(context),
         widget_(gfx::kNullAcceleratedWidget),
         waiting_for_event_ack_(false) {}
   virtual ~NativeViewportImpl() {
     // Destroy the NativeViewport early on as it may call us back during
     // destruction and we want to be in a known state.
     native_viewport_.reset();
   }
 
-  virtual void Create(const Rect& bounds) OVERRIDE {
+  virtual void Create(RectPtr bounds) OVERRIDE {
     native_viewport_ =
         services::NativeViewport::Create(context_, this);
-    native_viewport_->Init(bounds);
+    native_viewport_->Init(bounds.To<gfx::Rect>());
     client()->OnCreated();
-    OnBoundsChanged(bounds);
+    OnBoundsChanged(bounds.To<gfx::Rect>());
   }
 
   virtual void Show() OVERRIDE {
     native_viewport_->Show();
   }
 
   virtual void Hide() OVERRIDE {
     native_viewport_->Hide();
   }
 
   virtual void Close() OVERRIDE {
     command_buffer_.reset();
     DCHECK(native_viewport_);
     native_viewport_->Close();
   }
 
-  virtual void SetBounds(const Rect& bounds) OVERRIDE {
-    gfx::Rect gfx_bounds(bounds.position().x(), bounds.position().y(),
-                         bounds.size().width(), bounds.size().height());
+  virtual void SetBounds(RectPtr bounds) OVERRIDE {
+    gfx::Rect gfx_bounds(bounds->position->x, bounds->position->y,
+                         bounds->size->width, bounds->size->height);
     native_viewport_->SetBounds(gfx_bounds);
   }
 
   virtual void CreateGLES2Context(ScopedMessagePipeHandle client_handle)
       OVERRIDE {
     if (command_buffer_.get() || command_buffer_handle_.is_valid()) {
       LOG(ERROR) << "Can't create multiple contexts on a NativeViewport";
       return;
     }
 
@@ skipping 32 matching lines @@
     case ui::ET_TOUCH_RELEASED:
       native_viewport_->ReleaseCapture();
       break;
     default:
       break;
     }
 
     if (waiting_for_event_ack_ && IsRateLimitedEventType(ui_event))
       return false;
 
-    AllocationScope scope;
-
-    Event::Builder event;
-    event.set_action(ui_event->type());
-    event.set_flags(ui_event->flags());
-    event.set_time_stamp(ui_event->time_stamp().ToInternalValue());
+    EventPtr event(Event::New());
+    event->action = ui_event->type();
+    event->flags = ui_event->flags();
+    event->time_stamp = ui_event->time_stamp().ToInternalValue();
 
     if (ui_event->IsMouseEvent() || ui_event->IsTouchEvent()) {
       ui::LocatedEvent* located_event =
           static_cast<ui::LocatedEvent*>(ui_event);
-      Point::Builder location;
-      location.set_x(located_event->location().x());
-      location.set_y(located_event->location().y());
-      event.set_location(location.Finish());
+      event->location = Point::New();
+      event->location->x = located_event->location().x();
+      event->location->y = located_event->location().y();
     }
 
     if (ui_event->IsTouchEvent()) {
       ui::TouchEvent* touch_event = static_cast<ui::TouchEvent*>(ui_event);
-      TouchData::Builder touch_data;
-      touch_data.set_pointer_id(touch_event->touch_id());
-      event.set_touch_data(touch_data.Finish());
+      event->touch_data = TouchData::New();
+      event->touch_data->pointer_id = touch_event->touch_id();
     } else if (ui_event->IsKeyEvent()) {
       ui::KeyEvent* key_event = static_cast<ui::KeyEvent*>(ui_event);
-      KeyData::Builder key_data;
-      key_data.set_key_code(key_event->key_code());
-      key_data.set_is_char(key_event->is_char());
-      event.set_key_data(key_data.Finish());
+      event->key_data = KeyData::New();
+      event->key_data->key_code = key_event->key_code();
+      event->key_data->is_char = key_event->is_char();
     }
 
-    client()->OnEvent(event.Finish(),
-                     base::Bind(&NativeViewportImpl::AckEvent,
-                                base::Unretained(this)));
+    client()->OnEvent(event.Pass(),
+                      base::Bind(&NativeViewportImpl::AckEvent,
+                                 base::Unretained(this)));
     waiting_for_event_ack_ = true;
     return false;
   }
 
   virtual void OnAcceleratedWidgetAvailable(
       gfx::AcceleratedWidget widget) OVERRIDE {
     widget_ = widget;
     CreateCommandBufferIfNeeded();
   }
 
   virtual void OnBoundsChanged(const gfx::Rect& bounds) OVERRIDE {
     CreateCommandBufferIfNeeded();
-    AllocationScope scope;
-    client()->OnBoundsChanged(bounds);
+    client()->OnBoundsChanged(Rect::From(bounds));
   }
 
   virtual void OnDestroyed() OVERRIDE {
     command_buffer_.reset();
     client()->OnDestroyed();
     base::MessageLoop::current()->Quit();
   }
 
  private:
   shell::Context* context_;
   gfx::AcceleratedWidget widget_;
   scoped_ptr<services::NativeViewport> native_viewport_;
   ScopedMessagePipeHandle command_buffer_handle_;
   scoped_ptr<CommandBufferImpl> command_buffer_;
   bool waiting_for_event_ack_;
 };
 
 }  // namespace services
 }  // namespace mojo
 
 
 MOJO_NATIVE_VIEWPORT_EXPORT mojo::Application*
     CreateNativeViewportService(mojo::shell::Context* context,
                                 mojo::ScopedMessagePipeHandle shell_handle) {
   mojo::Application* app = new mojo::Application(shell_handle.Pass());
   app->AddService<mojo::services::NativeViewportImpl>(context);
   return app;
 }