Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6320)

Unified Diff: chrome/common/page_load_metrics/page_load_metrics_param_traits.h

Issue 2948323002: [PageLoadMetrics] Remove legacy IPC from Page Load Metrics. (Closed)
Patch Set: Clean up OWNERS Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/page_load_metrics/page_load_metrics_param_traits.h
diff --git a/chrome/common/page_load_metrics/page_load_metrics_param_traits.h b/chrome/common/page_load_metrics/page_load_metrics_param_traits.h
deleted file mode 100644
index 7f84dcfdd242c4bfb5bbb12ecd2ec65a44651160..0000000000000000000000000000000000000000
--- a/chrome/common/page_load_metrics/page_load_metrics_param_traits.h
+++ /dev/null
@@ -1,32 +0,0 @@
-// Copyright (c) 2017 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_COMMON_PAGE_LOAD_METRICS_PAGE_LOAD_METRICS_PARAM_TRAITS_H_
-#define CHROME_COMMON_PAGE_LOAD_METRICS_PAGE_LOAD_METRICS_PARAM_TRAITS_H_
-
-#include "chrome/common/page_load_metrics/page_load_metrics.mojom.h"
-#include "ipc/ipc_message_utils.h"
-
-namespace IPC {
-
-// mojom::PageLoadTiming contains child mojom structs, which are stored in
-// mojo::StructPtr<>s. IPC doesn't have ParamTraits for mojo::StructPtr<>, so we
-// provide custom ParamTraits for PageLoadTiming here. This is temporary while
-// we run a field trial to verify there are no metric regressions due to
-// migrating to mojo, and will be removed once the field trial is complete and
-// shows expected results.
-template <>
-struct ParamTraits<page_load_metrics::mojom::PageLoadTiming> {
- typedef page_load_metrics::mojom::PageLoadTiming param_type;
- static void GetSize(base::PickleSizer* s, const param_type& p);
- static void Write(base::Pickle* m, const param_type& p);
- static bool Read(const base::Pickle* m,
- base::PickleIterator* iter,
- param_type* p);
- static void Log(const param_type& p, std::string* l);
-};
-
-} // namespace IPC
-
-#endif // CHROME_COMMON_PAGE_LOAD_METRICS_PAGE_LOAD_METRICS_PARAM_TRAITS_H_

Powered by Google App Engine
This is Rietveld 408576698