[PageLoadMetrics] Remove legacy IPC from Page Load Metrics.

chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/page_load_metrics/metrics_render_frame_observer.h"
 
 #include <string>
 
-#include "base/feature_list.h"
 #include "base/memory/ptr_util.h"
 #include "base/time/time.h"
 #include "base/timer/timer.h"
-#include "chrome/common/chrome_features.h"
-#include "chrome/common/page_load_metrics/page_load_metrics_messages.h"
 #include "chrome/renderer/page_load_metrics/page_timing_metrics_sender.h"
 #include "chrome/renderer/page_load_metrics/page_timing_sender.h"
 #include "chrome/renderer/page_load_metrics/renderer_page_track_decider.h"
 #include "chrome/renderer/searchbox/search_bouncer.h"
 #include "content/public/common/associated_interface_provider.h"
 #include "content/public/renderer/render_frame.h"
 #include "third_party/WebKit/public/web/WebDataSource.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
 #include "third_party/WebKit/public/web/WebPerformance.h"
 #include "url/gurl.h"
 
 namespace page_load_metrics {
 
 namespace {
 
 base::TimeDelta ClampDelta(double event, double start) {
   if (event - start < 0)
     event = start;
   return base::Time::FromDoubleT(event) - base::Time::FromDoubleT(start);
 }
 
-class LegacyIPCPageTimingSender : public PageTimingSender {
+class MojoPageTimingSender : public PageTimingSender {
  public:
-  LegacyIPCPageTimingSender(content::RenderFrame* render_frame,
-                            const int routing_id)
-      : render_frame_(render_frame), routing_id_(routing_id) {}
-  ~LegacyIPCPageTimingSender() override {}
-
-  void SendTiming(const mojom::PageLoadTimingPtr& timing,
-                  const mojom::PageLoadMetadataPtr& metadata) override {
-    DCHECK(render_frame_);
-    render_frame_->Send(
-        new PageLoadMetricsMsg_TimingUpdated(routing_id_, *timing, *metadata));
-  }
-
- private:
-  content::RenderFrame* const render_frame_;
-  const int routing_id_;
-};
-
-class MojoIPCPageTimingSender : public PageTimingSender {
- public:
-  explicit MojoIPCPageTimingSender(content::RenderFrame* render_frame) {
+  explicit MojoPageTimingSender(content::RenderFrame* render_frame) {
     DCHECK(render_frame);
     render_frame->GetRemoteAssociatedInterfaces()->GetInterface(
         &page_load_metrics_);
   }
-  ~MojoIPCPageTimingSender() override {}
+  ~MojoPageTimingSender() override {}
   void SendTiming(const mojom::PageLoadTimingPtr& timing,
                   const mojom::PageLoadMetadataPtr& metadata) override {
     DCHECK(page_load_metrics_);
     page_load_metrics_->UpdateTiming(timing->Clone(), metadata->Clone());
   }
 
  private:
   // Use associated interface to make sure mojo messages are ordered with regard
   // to legacy IPC messages.
   mojom::PageLoadMetricsAssociatedPtr page_load_metrics_;
@@ skipping 132 matching lines @@
   }
   return timing;
 }
 
 std::unique_ptr<base::Timer> MetricsRenderFrameObserver::CreateTimer() {
   return base::MakeUnique<base::OneShotTimer>();
 }
 
 std::unique_ptr<PageTimingSender>
 MetricsRenderFrameObserver::CreatePageTimingSender() {
-  if (base::FeatureList::IsEnabled(features::kPageLoadMetricsMojofication)) {
-    return base::WrapUnique<PageTimingSender>(
-        new MojoIPCPageTimingSender(render_frame()));
-  }
   return base::WrapUnique<PageTimingSender>(

[dcheng, 2017/06/25 07:44:46]

Nit: not introduced by this CL, but WrapUnique's template parameter should not
be specified (the whole point of WrapUnique is to auto-deduce the appropriate
type)

-      new LegacyIPCPageTimingSender(render_frame(), routing_id()));
+      new MojoPageTimingSender(render_frame()));

[dcheng, 2017/06/25 07:44:46]

Nit: though we should just prefer base::MakeUnique, as the constructor is public
anyway.

 }
 
 bool MetricsRenderFrameObserver::HasNoRenderFrame() const {
   bool no_frame = !render_frame() || !render_frame()->GetWebFrame();
   DCHECK(!no_frame);
   return no_frame;
 }
 
 void MetricsRenderFrameObserver::OnDestruct() {
   delete this;
 }
 
 }  // namespace page_load_metrics