Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1449)

Unified Diff: runtime/bin/loader.cc

Issue 2948273002: Correctly set root_library based on the application script URI instead of looking for the library t… (Closed)
Patch Set: Integrate cl from Siggi for front end change to not require a 'main' method when using the memory f… Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/gen_snapshot.cc ('k') | runtime/bin/main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/loader.cc
diff --git a/runtime/bin/loader.cc b/runtime/bin/loader.cc
index f67c724568614911691de233d7241e6da46a3ca8..13465f24a988e4b7dcc62848cbf698638068452e 100644
--- a/runtime/bin/loader.cc
+++ b/runtime/bin/loader.cc
@@ -431,8 +431,9 @@ bool Loader::ProcessResultLocked(Loader* loader, Loader::IOResult* result) {
// isolates. We currently do not have support for neither
// `Isolate.spawn()` nor `Isolate.spawnUri()` with kernel-based
// frontend.
- void* kernel_binary = Dart_ReadKernelBinary(payload, payload_length);
- dart_result = Dart_LoadKernel(kernel_binary);
+ Dart_Handle kernel_binary = reinterpret_cast<Dart_Handle>(
+ Dart_ReadKernelBinary(payload, payload_length));
+ dart_result = Dart_LoadScript(uri, resolved_uri, kernel_binary, 0, 0);
} else {
dart_result = Dart_LoadScript(uri, resolved_uri, source, 0, 0);
}
« no previous file with comments | « runtime/bin/gen_snapshot.cc ('k') | runtime/bin/main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698