Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 294823002: Treat IPv4-mapped IPv6 addresses as IPv4 addresses. (Closed)

Created:
6 years, 7 months ago by wtc
Modified:
6 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

Treat IPv4-mapped IPv6 addresses as IPv4 addresses. Rename the Net.QuicSession.PublicResetAddressMismatch histogram to Net.QuicSession.PublicResetAddressMismatch2. R=jar@chromium.org,rch@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271759

Patch Set 1 #

Total comments: 4

Patch Set 2 : Change histogram owners #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -7 lines) Patch
M net/quic/quic_address_mismatch.cc View 2 chunks +11 lines, -3 lines 0 comments Download
M net/quic/quic_address_mismatch_test.cc View 5 chunks +41 lines, -0 lines 0 comments Download
M net/quic/quic_connection_logger.cc View 4 chunks +10 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +14 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
wtc
https://codereview.chromium.org/294823002/diff/1/net/quic/quic_connection_logger.cc File net/quic/quic_connection_logger.cc (right): https://codereview.chromium.org/294823002/diff/1/net/quic/quic_connection_logger.cc#newcode439 net/quic/quic_connection_logger.cc:439: UMA_HISTOGRAM_ENUMERATION("Net.QuicSession.ConnectionTypeFromSelf", Ryan: on your suggestion, I didn't rename your ...
6 years, 7 months ago (2014-05-19 23:24:11 UTC) #1
Ryan Hamilton
lgtm https://codereview.chromium.org/294823002/diff/1/net/quic/quic_connection_logger.cc File net/quic/quic_connection_logger.cc (right): https://codereview.chromium.org/294823002/diff/1/net/quic/quic_connection_logger.cc#newcode440 net/quic/quic_connection_logger.cc:440: GetRealAddressFamily(self_address.address()), I believe we don't need to do ...
6 years, 7 months ago (2014-05-20 00:26:35 UTC) #2
wtc
The CQ bit was checked by wtc@chromium.org
6 years, 7 months ago (2014-05-20 16:36:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/294823002/20001
6 years, 7 months ago (2014-05-20 16:36:36 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 18:46:02 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 18:52:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/68699)
6 years, 7 months ago (2014-05-20 18:52:05 UTC) #7
jar (doing other things)
lgtm
6 years, 7 months ago (2014-05-20 21:21:49 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 21:33:04 UTC) #9
Message was sent while issue was closed.
Change committed as 271759

Powered by Google App Engine
This is Rietveld 408576698