Fix end of line announcements

chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js
index 4a729cbc796c57e6e57fc24d73607204c2235fb2..a679a41658593bf09f3116bb4c41ca6c0d9dbfde 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js
@@ -391,9 +391,15 @@ AutomationRichEditableText.prototype = {
 
   /** @override */
   describeSelectionChanged: function(evt) {
-    // Ignore end of text announcements.
-    if ((this.start + 1) == evt.start && evt.start == this.value.length)
+    // Note that since Chrome allows for selection to be placed immediately at
+    // the end of a line (i.e. end == value.length) and since we try to describe
+    // the character to the right, this state has very little meaning in most

[dmazzoni, 2017/06/23 18:31:45]

I don't know what you mean by "this state has very little meaning".
Would it be sufficient to just say "Describe it as a new line"?

[David Tseng, 2017/06/23 19:17:07]

It has little meaning because there's no character to the right on the same
line.
I removed the comment.

+    // cases. Describe it as a new line. In braille, we simply show the cursor
+    // one cell to the right of the last character.
+    if ((this.start + 1) == evt.start && evt.start == this.value.length) {
+      this.speak('\n', evt.triggeredByUser);
       return;
+    }
 
     cvox.ChromeVoxEditableTextBase.prototype.describeSelectionChanged.call(
         this, evt);