Fix end of line announcements

chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Processes events related to editing text and emits the
  * appropriate spoken and braille feedback.
  */
 
 goog.provide('editing.TextEditHandler');
@@ skipping 373 matching lines @@
     var value = cur.value_;
     value.setSpan(new cvox.ValueSpan(0), 0, cur.value_.length);
     value.setSpan(
         new cvox.ValueSelectionSpan(), cur.startOffset, cur.endOffset);
     cvox.ChromeVox.braille.write(new cvox.NavBraille(
         {text: value, startIndex: cur.startOffset, endIndex: cur.endOffset}));
   },
 
   /** @override */
   describeSelectionChanged: function(evt) {
-    // Ignore end of text announcements.
-    if ((this.start + 1) == evt.start && evt.start == this.value.length)
+    // Note that since Chrome allows for selection to be placed immediately at
+    // the end of a line (i.e. end == value.length) and since we try to describe
+    // the character to the right, this state has very little meaning in most

[dmazzoni, 2017/06/23 18:31:45]

I don't know what you mean by "this state has very little meaning".
Would it be sufficient to just say "Describe it as a new line"?

[David Tseng, 2017/06/23 19:17:07]

It has little meaning because there's no character to the right on the same
line.
I removed the comment.

+    // cases. Describe it as a new line. In braille, we simply show the cursor
+    // one cell to the right of the last character.
+    if ((this.start + 1) == evt.start && evt.start == this.value.length) {
+      this.speak('\n', evt.triggeredByUser);
       return;
+    }
 
     cvox.ChromeVoxEditableTextBase.prototype.describeSelectionChanged.call(
         this, evt);
   },
 
   /** @override */
   getLineIndex: function(charIndex) {
     return 0;
   },
 
@@ skipping 338 matching lines @@
    * @return {boolean}
    */
   isSameLineAndSelection: function(otherLine) {
     return this.isSameLine(otherLine) &&
         this.startOffset == otherLine.startOffset &&
         this.endOffset == otherLine.endOffset;
   }
 };
 
 });