Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2948153004: Correct merge errors in co19 roll (Closed)

Created:
3 years, 6 months ago by Bill Hesse
Modified:
3 years, 6 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Correct merge errors in co19 roll This corrects merge errors found in the commit of https://codereview.chromium.org/2954443002/ BUG= R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/3078734ff78920ee786f5313d8989f01dc7e487a

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -43 lines) Patch
M tests/co19/co19-dart2js.status View 1 28 chunks +26 lines, -36 lines 0 comments Download
M tests/co19/co19-dartium.status View 3 chunks +1 line, -4 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Bill Hesse
I think this should cover failures caused by the last commit. We can check to ...
3 years, 6 months ago (2017-06-22 11:30:37 UTC) #2
kustermann
lgtm https://codereview.chromium.org/2948153004/diff/1/tests/co19/co19-dart2js.status File tests/co19/co19-dart2js.status (right): https://codereview.chromium.org/2948153004/diff/1/tests/co19/co19-dart2js.status#newcode4074 tests/co19/co19-dart2js.status:4074: Language/Statements/Yield_and_Yield_Each/Yield/execution_async_t04: Pass,RuntimeError # Issue 26615 Pass, Fail is ...
3 years, 6 months ago (2017-06-22 11:38:58 UTC) #3
Bill Hesse
https://codereview.chromium.org/2948153004/diff/1/tests/co19/co19-dart2js.status File tests/co19/co19-dart2js.status (right): https://codereview.chromium.org/2948153004/diff/1/tests/co19/co19-dart2js.status#newcode4074 tests/co19/co19-dart2js.status:4074: Language/Statements/Yield_and_Yield_Each/Yield/execution_async_t04: Pass,RuntimeError # Issue 26615 On 2017/06/22 11:38:57, kustermann ...
3 years, 6 months ago (2017-06-22 11:47:09 UTC) #4
Bill Hesse
3 years, 6 months ago (2017-06-22 11:47:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3078734ff78920ee786f5313d8989f01dc7e487a.

Powered by Google App Engine
This is Rietveld 408576698