Issue 2948153003: VM: Fix fragile shaker test after changes to hash code storage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2948153003: VM: Fix fragile shaker test after changes to hash code storage. (Closed)

Created:
3 years, 6 months ago by erikcorry

Modified:
3 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Fix fragile shaker test after changes to hash code storage. R=vegorov@google.com BUG=

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	pkg/front_end/testcases/shaker/empty_program.dart.shaker	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	runtime/vm/object.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

erikcorry

3 years, 6 months ago (2017-06-22 08:19:49 UTC) #3

Abandoned in favour of a full revert after another test failure turned up on
real ARM64 hardware.