Add auto-refresh support to OAuthTokenGetter (disabled for now).

Add auto-refresh support to OAuthTokenGetter (disabled for now).

Some fixes to GetUserInfo flow to avoid superfluous GetUserInfo calls.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271795

[Sergey Ulanov, 2014-05-19 22:33:46]

https://codereview.chromium.org/294813002/diff/1/remoting/host/oauth_token_ge...
File remoting/host/oauth_token_getter.cc (right):

https://codereview.chromium.org/294813002/diff/1/remoting/host/oauth_token_ge...
remoting/host/oauth_token_getter.cc:142: || base::Time::Now() >=
auth_token_expiry_time_
nit: || should not be wrapped.

https://codereview.chromium.org/294813002/diff/1/remoting/host/oauth_token_ge...
File remoting/host/oauth_token_getter.h (right):

https://codereview.chromium.org/294813002/diff/1/remoting/host/oauth_token_ge...
remoting/host/oauth_token_getter.h:62: bool auto_refresh);
Why do we need both this flag and EnableAutoRefresh()?
I would prefer having only EnableAutoRefresh().

[rmsousa, 2014-05-19 22:46:53]

https://codereview.chromium.org/294813002/diff/1/remoting/host/oauth_token_ge...
File remoting/host/oauth_token_getter.cc (right):

https://codereview.chromium.org/294813002/diff/1/remoting/host/oauth_token_ge...
remoting/host/oauth_token_getter.cc:142: || base::Time::Now() >=
auth_token_expiry_time_
On 2014/05/19 22:33:46, Sergey Ulanov wrote:
> nit: || should not be wrapped. 

it's the opposite in Java, I always get confused whenever I change languages :)

https://codereview.chromium.org/294813002/diff/1/remoting/host/oauth_token_ge...
File remoting/host/oauth_token_getter.h (right):

https://codereview.chromium.org/294813002/diff/1/remoting/host/oauth_token_ge...
remoting/host/oauth_token_getter.h:62: bool auto_refresh);
On 2014/05/19 22:33:46, Sergey Ulanov wrote:
> Why do we need both this flag and EnableAutoRefresh()?
> I would prefer having only EnableAutoRefresh().

I forgot to delete EnableAutoRefresh() from here (there's no implementation).

I started with EnableAutoRefresh(), but started getting complicated (It'd either
have to be restricted so it's a one-shot that must be called just after the
constructor, before any CallWithToken calls, or we'd have to handle the cases
where AutoRefresh is enabled/disabled with a current token/expiration, or there
is a refresh in-flight, etc).

Let me know if you prefer either of those alternatives.

[Sergey Ulanov, 2014-05-20 00:27:51]

lgtm

[dcaiafa, 2014-05-20 00:43:34]

lgtm

[rmsousa, 2014-05-20 00:56:00]

The CQ bit was checked by rmsousa@chromium.org

[commit-bot: I haz the power, 2014-05-20 00:56:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rmsousa@chromium.org/294813002/20001

[commit-bot: I haz the power, 2014-05-20 04:15:34]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-20 05:32:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-20 05:32:40]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[rmsousa, 2014-05-20 21:18:49]

The CQ bit was checked by rmsousa@chromium.org

[commit-bot: I haz the power, 2014-05-20 21:22:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rmsousa@chromium.org/294813002/20001

[commit-bot: I haz the power, 2014-05-21 01:39:49]

Change committed as 271795