Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html

Issue 2948023002: Fix periodic dumping for memory-infra on Android. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html
diff --git a/tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html b/tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html
index 0971bb93c1395a7f0d40c2a79229bfe811119706..4970ea5363f5effb5ecc499bde7bb689751e89ab 100644
--- a/tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html
+++ b/tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html
@@ -91,14 +91,24 @@ tr.exportTo('tr.ui.e.about_tracing', function() {
throw new Error('Already recording');
}
this.recording_ = 'starting';
+ const memoryConfig = { triggers: [] };
+ if (recordingOptions.includedCategories.indexOf(
+ 'disabled-by-default-memory-infra') !== -1) {
+ memoryConfig.triggers.push(
+ {'mode': 'detailed', 'periodic_interval_ms': 10000});
+ }
+
+ const traceConfigStr = {
+ includedCategories: recordingOptions.includedCategories,
+ excludedCategories: recordingOptions.excludedCategories,
+ memoryDumpConfig: memoryConfig,
+ recordMode: recordingOptions.tracingRecordMode,
+ enableSystrace: recordingOptions.useSystemTracing
+ };
let res = this.conn_.req(
'Tracing.start',
{
- categories: recordingOptions.categoryFilter,
- options:
- [recordingOptions.tracingRecordMode,
- (recordingOptions.useSampling ? 'enable-sampling' : '')
ssid 2017/06/21 18:59:20 +Andrey can you verify this is not required? I can
erikchen 2017/06/21 22:56:50 This is dead code, which is why I removed it. The
fmeawad 2017/06/22 23:16:39 I can confirm that this is dead code, this is not
- ].join(','),
+ traceConfig: traceConfigStr,
bufferUsageReportingInterval: 1000
});
res = res.then(

Powered by Google App Engine
This is Rietveld 408576698