Issue 294793002: Update GCD prototype

Issue 294793002: Update GCD prototype (Closed)

Created:
6 years, 7 months ago by Noam Samuel

Modified:
6 years, 7 months ago

Reviewers:
Vitaly Buka (NO REVIEWS)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update GCD prototype 1. Take OAuth client ID in JSON 2. Use protocol from devsite (still needs work) NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271505

Patch Set 4 : #

Total comments: 2

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -48 lines)			Patch
	M	components/cloud_devices/tools/prototype/prototype.py	View	1 2 3	13 chunks	+63 lines, -48 lines	2 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/294793002/60001

6 years, 7 months ago (2014-05-19 22:28:33 UTC) #3

Vitaly Buka (NO REVIEWS)

https://codereview.chromium.org/294793002/diff/60001/components/cloud_devices/tools/prototype/prototype.py File components/cloud_devices/tools/prototype/prototype.py (right): https://codereview.chromium.org/294793002/diff/60001/components/cloud_devices/tools/prototype/prototype.py#newcode799 components/cloud_devices/tools/prototype/prototype.py:799: specific_info["setup"]["registration"] = "available" not implemented?

6 years, 7 months ago (2014-05-20 00:27:30 UTC) #5

Noam Samuel

6 years, 7 months ago (2014-05-20 18:12:49 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/294793002/diff/60001/components/cloud_devices...
File components/cloud_devices/tools/prototype/prototype.py (right):

https://codereview.chromium.org/294793002/diff/60001/components/cloud_devices...
components/cloud_devices/tools/prototype/prototype.py:799:
specific_info["setup"]["registration"] = "available"
On 2014/05/20 00:27:30, Vitaly Buka wrote:
> not implemented?

Oh whoops. I'll correct that in a followup.

Expand Messages | Collapse Messages