Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 294783003: don't show border on hover for guest label in profile chooser view (Closed)

Created:
6 years, 7 months ago by Evan Stade
Modified:
6 years, 7 months ago
Reviewers:
noms (inactive), sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

don't show border on hover for guest label in profile chooser view BUG=374758 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272510

Patch Set 1 #

Patch Set 2 : dont delete that #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
Evan Stade
6 years, 7 months ago (2014-05-19 22:09:26 UTC) #1
Evan Stade
(see bug for backstory)
6 years, 7 months ago (2014-05-19 22:10:13 UTC) #2
noms (inactive)
LGTM. Thanks for the fix!
6 years, 7 months ago (2014-05-20 13:27:04 UTC) #3
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 7 months ago (2014-05-20 17:32:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/294783003/20001
6 years, 7 months ago (2014-05-20 17:33:04 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 21:16:03 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 21:18:47 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/29125)
6 years, 7 months ago (2014-05-20 21:18:47 UTC) #8
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 7 months ago (2014-05-22 19:15:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/294783003/20001
6 years, 7 months ago (2014-05-22 19:16:30 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 20:29:36 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 20:35:43 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/69320)
6 years, 7 months ago (2014-05-22 20:35:44 UTC) #13
Evan Stade
+sky for OWNERS stamp
6 years, 7 months ago (2014-05-23 02:06:02 UTC) #14
sky
LGTM
6 years, 7 months ago (2014-05-23 13:23:07 UTC) #15
sky
The CQ bit was checked by sky@chromium.org
6 years, 7 months ago (2014-05-23 13:23:14 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/294783003/20001
6 years, 7 months ago (2014-05-23 13:23:34 UTC) #17
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 13:30:01 UTC) #18
Message was sent while issue was closed.
Change committed as 272510

Powered by Google App Engine
This is Rietveld 408576698