Remove SVGSymbolElement::selfHasRelativeLengths

Remove SVGSymbolElement::selfHasRelativeLengths

Since <symbol> is cloned into the shadow tree I see no reason why it should have this method. But for this to work <use> has to delegate its selfHasRelativeLengths to the shadow tree element instead of the corresponding element, so change that behavior too.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174881

[rwlbuis, 2014-05-20 17:31:33]

PTAL. The fails are just indicating there are less repaints, which must be a
good thing (since ultimately the image comparisons still pass).

[rwlbuis, 2014-05-20 17:32:49]

Oops *pdr*, not pbr :)

[pdr., 2014-05-21 06:06:20]

LGTM.

Nit: change description uses <switch> which threw me for a loop reviewing this.
Should be <symbol> :)

https://codereview.chromium.org/294783002/diff/10001/Source/core/svg/SVGSymbo...
File Source/core/svg/SVGSymbolElement.cpp (left):

https://codereview.chromium.org/294783002/diff/10001/Source/core/svg/SVGSymbo...
Source/core/svg/SVGSymbolElement.cpp:74: updateRelativeLengthsInformation();
Can we remove this too, or is it required even in the shadow tree?

[rwlbuis, 2014-05-21 21:46:25]

On 2014/05/21 06:06:20, pdr wrote:
> LGTM.
> 
> Nit: change description uses <switch> which threw me for a loop reviewing
this.
> Should be <symbol> :)

Yes, I was not thinking straight when I wrote that :}

>
https://codereview.chromium.org/294783002/diff/10001/Source/core/svg/SVGSymbo...
> File Source/core/svg/SVGSymbolElement.cpp (left):
> 
>
https://codereview.chromium.org/294783002/diff/10001/Source/core/svg/SVGSymbo...
> Source/core/svg/SVGSymbolElement.cpp:74: updateRelativeLengthsInformation();
> Can we remove this too, or is it required even in the shadow tree?

I think that works, I already had that in mind. Alas we have to wait for the
linux bot to show up green.... Then I will mark it as Rebaseline for the other
platforms.

[pdr., 2014-05-27 16:06:56]

On 2014/05/21 21:46:25, rwlbuis wrote:
> On 2014/05/21 06:06:20, pdr wrote:
> > LGTM.
> > 
> > Nit: change description uses <switch> which threw me for a loop reviewing
> this.
> > Should be <symbol> :)
> 
> Yes, I was not thinking straight when I wrote that :}
> 
> >
>
https://codereview.chromium.org/294783002/diff/10001/Source/core/svg/SVGSymbo...
> > File Source/core/svg/SVGSymbolElement.cpp (left):
> > 
> >
>
https://codereview.chromium.org/294783002/diff/10001/Source/core/svg/SVGSymbo...
> > Source/core/svg/SVGSymbolElement.cpp:74: updateRelativeLengthsInformation();
> > Can we remove this too, or is it required even in the shadow tree?
> 
> I think that works, I already had that in mind. Alas we have to wait for the
> linux bot to show up green.... Then I will mark it as Rebaseline for the other
> platforms.
?
There hasn't been an update on this patch but it's a good one. Did you hit a
roadblock?

[rwlbuis, 2014-05-27 17:09:20]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-05-27 17:09:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rob.buis@samsung.com/294783002/50001

[commit-bot: I haz the power, 2014-05-27 18:39:44]

Change committed as 174881