CacheStorage: Migrate to BindOnce/OnceCallback/OnceClosure

content/browser/cache_storage/cache_storage_cache.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/cache_storage/cache_storage_cache.h"
 
 #include <stddef.h>
 #include <algorithm>
 #include <limits>
 #include <memory>
@@ skipping 51 matching lines @@
 
  private:
   ~CacheStorageCacheDataHandle() override {}
 
   std::unique_ptr<CacheStorageCacheHandle> cache_handle_;
   disk_cache::ScopedEntryPtr entry_;
 
   DISALLOW_COPY_AND_ASSIGN(CacheStorageCacheDataHandle);
 };
 
-typedef base::Callback<void(std::unique_ptr<proto::CacheMetadata>)>
-    MetadataCallback;
+using MetadataCallback =
+    base::OnceCallback<void(std::unique_ptr<proto::CacheMetadata>)>;
 
 // The maximum size of each cache. Ultimately, cache size
 // is controlled per-origin by the QuotaManager.
 const int kMaxCacheBytes = std::numeric_limits<int>::max();
 
 blink::WebServiceWorkerResponseType ProtoResponseTypeToWebResponseType(
     proto::CacheResponse::ResponseType response_type) {
   switch (response_type) {
     case proto::CacheResponse::BASIC_TYPE:
       return blink::kWebServiceWorkerResponseTypeBasic;
@@ skipping 27 matching lines @@
       return proto::CacheResponse::OPAQUE_TYPE;
     case blink::kWebServiceWorkerResponseTypeOpaqueRedirect:
       return proto::CacheResponse::OPAQUE_REDIRECT_TYPE;
   }
   NOTREACHED();
   return proto::CacheResponse::OPAQUE_TYPE;
 }
 
 // Copy headers out of a cache entry and into a protobuf. The callback is
 // guaranteed to be run.
-void ReadMetadata(disk_cache::Entry* entry, const MetadataCallback& callback);
+void ReadMetadata(disk_cache::Entry* entry, MetadataCallback callback);
 void ReadMetadataDidReadMetadata(disk_cache::Entry* entry,
-                                 const MetadataCallback& callback,
+                                 MetadataCallback callback,
                                  scoped_refptr<net::IOBufferWithSize> buffer,
                                  int rv);
 
 bool VaryMatches(const ServiceWorkerHeaderMap& request,
                  const ServiceWorkerHeaderMap& cached_request,
                  const ServiceWorkerHeaderMap& response) {
   ServiceWorkerHeaderMap::const_iterator vary_iter = response.find("vary");
   if (vary_iter == response.end())
     return true;
 
@@ skipping 21 matching lines @@
 
   return true;
 }
 
 GURL RemoveQueryParam(const GURL& url) {
   url::Replacements<char> replacements;
   replacements.ClearQuery();
   return url.ReplaceComponents(replacements);
 }
 
-void ReadMetadata(disk_cache::Entry* entry, const MetadataCallback& callback) {
+void ReadMetadata(disk_cache::Entry* entry, MetadataCallback callback) {
   DCHECK(entry);
 
   scoped_refptr<net::IOBufferWithSize> buffer(new net::IOBufferWithSize(
       entry->GetDataSize(CacheStorageCache::INDEX_HEADERS)));
 
   net::CompletionCallback read_header_callback =
-      base::Bind(ReadMetadataDidReadMetadata, entry, callback, buffer);
+      base::AdaptCallbackForRepeating(base::BindOnce(
+          ReadMetadataDidReadMetadata, entry, std::move(callback), buffer));
 
   int read_rv =
       entry->ReadData(CacheStorageCache::INDEX_HEADERS, 0, buffer.get(),
                       buffer->size(), read_header_callback);
 
   if (read_rv != net::ERR_IO_PENDING)
     read_header_callback.Run(read_rv);
 }
 
 void ReadMetadataDidReadMetadata(disk_cache::Entry* entry,
-                                 const MetadataCallback& callback,
+                                 MetadataCallback callback,
                                  scoped_refptr<net::IOBufferWithSize> buffer,
                                  int rv) {
   if (rv != buffer->size()) {
-    callback.Run(std::unique_ptr<proto::CacheMetadata>());
+    std::move(callback).Run(std::unique_ptr<proto::CacheMetadata>());
     return;
   }
 
   if (rv > 0)
     storage::RecordBytesRead(kRecordBytesLabel, rv);
 
   std::unique_ptr<proto::CacheMetadata> metadata(new proto::CacheMetadata());
 
   if (!metadata->ParseFromArray(buffer->data(), buffer->size())) {
-    callback.Run(std::unique_ptr<proto::CacheMetadata>());
+    std::move(callback).Run(std::unique_ptr<proto::CacheMetadata>());
     return;
   }
 
-  callback.Run(std::move(metadata));
+  std::move(callback).Run(std::move(metadata));
 }
 
 std::unique_ptr<ServiceWorkerFetchRequest> CreateRequest(
     const proto::CacheMetadata& metadata,
     const GURL& request_url) {
   auto request = base::MakeUnique<ServiceWorkerFetchRequest>(
       request_url, metadata.request().method(), ServiceWorkerHeaderMap(),
       Referrer(), false);
 
   for (int i = 0; i < metadata.request().headers_size(); ++i) {
@@ skipping 42 matching lines @@
           metadata.response().cors_exposed_header_names().end()));
 }
 
 }  // namespace
 
 // The state needed to pass between CacheStorageCache::Put callbacks.
 struct CacheStorageCache::PutContext {
   PutContext(std::unique_ptr<ServiceWorkerFetchRequest> request,
              std::unique_ptr<ServiceWorkerResponse> response,
              std::unique_ptr<storage::BlobDataHandle> blob_data_handle,
-             const CacheStorageCache::ErrorCallback& callback)
+             CacheStorageCache::ErrorCallback callback)
       : request(std::move(request)),
         response(std::move(response)),
         blob_data_handle(std::move(blob_data_handle)),
-        callback(callback) {}
+        callback(std::move(callback)) {}
 
   // Input parameters to the Put function.
   std::unique_ptr<ServiceWorkerFetchRequest> request;
   std::unique_ptr<ServiceWorkerResponse> response;
   std::unique_ptr<storage::BlobDataHandle> blob_data_handle;
   CacheStorageCache::ErrorCallback callback;
   disk_cache::ScopedEntryPtr cache_entry;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(PutContext);
 };
 
 struct CacheStorageCache::QueryCacheResult {
   explicit QueryCacheResult(base::Time entry_time) : entry_time(entry_time) {}
 
   std::unique_ptr<ServiceWorkerFetchRequest> request;
   std::unique_ptr<ServiceWorkerResponse> response;
   std::unique_ptr<storage::BlobDataHandle> blob_handle;
   disk_cache::ScopedEntryPtr entry;
   base::Time entry_time;
 };
 
 struct CacheStorageCache::QueryCacheContext {
   QueryCacheContext(std::unique_ptr<ServiceWorkerFetchRequest> request,
                     const CacheStorageCacheQueryParams& options,
-                    const QueryCacheCallback& callback)
+                    QueryCacheCallback callback)
       : request(std::move(request)),
         options(options),
-        callback(callback),
+        callback(std::move(callback)),
         matches(base::MakeUnique<QueryCacheResults>()) {}
 
   ~QueryCacheContext() {
     // If the CacheStorageCache is deleted before a backend operation to open
     // an entry completes, the callback won't be run and the resulting entry
     // will be leaked unless we close it here.
     if (enumerated_entry) {
       enumerated_entry->Close();
       enumerated_entry = nullptr;
     }
@@ skipping 52 matching lines @@
   return base::WrapUnique(cache);
 }
 
 base::WeakPtr<CacheStorageCache> CacheStorageCache::AsWeakPtr() {
   return weak_ptr_factory_.GetWeakPtr();
 }
 
 void CacheStorageCache::Match(
     std::unique_ptr<ServiceWorkerFetchRequest> request,
     const CacheStorageCacheQueryParams& match_params,
-    const ResponseCallback& callback) {
+    ResponseCallback callback) {
   if (backend_state_ == BACKEND_CLOSED) {
-    callback.Run(CACHE_STORAGE_ERROR_STORAGE,
-                 std::unique_ptr<ServiceWorkerResponse>(),
-                 std::unique_ptr<storage::BlobDataHandle>());
+    std::move(callback).Run(CACHE_STORAGE_ERROR_STORAGE,
+                            std::unique_ptr<ServiceWorkerResponse>(),
+                            std::unique_ptr<storage::BlobDataHandle>());
     return;
   }
 
-  scheduler_->ScheduleOperation(
-      base::Bind(&CacheStorageCache::MatchImpl, weak_ptr_factory_.GetWeakPtr(),
-                 base::Passed(std::move(request)), match_params,
-                 scheduler_->WrapCallbackToRunNext(callback)));
+  scheduler_->ScheduleOperation(base::BindOnce(
+      &CacheStorageCache::MatchImpl, weak_ptr_factory_.GetWeakPtr(),
+      base::Passed(std::move(request)), match_params,
+      scheduler_->WrapCallbackToRunNext(std::move(callback))));
 }
 
 void CacheStorageCache::MatchAll(
     std::unique_ptr<ServiceWorkerFetchRequest> request,
     const CacheStorageCacheQueryParams& match_params,
-    const ResponsesCallback& callback) {
+    ResponsesCallback callback) {
   if (backend_state_ == BACKEND_CLOSED) {
-    callback.Run(CACHE_STORAGE_ERROR_STORAGE, std::unique_ptr<Responses>(),
-                 std::unique_ptr<BlobDataHandles>());
+    std::move(callback).Run(CACHE_STORAGE_ERROR_STORAGE,
+                            std::unique_ptr<Responses>(),
+                            std::unique_ptr<BlobDataHandles>());
     return;
   }
 
-  scheduler_->ScheduleOperation(base::Bind(
+  scheduler_->ScheduleOperation(base::BindOnce(
       &CacheStorageCache::MatchAllImpl, weak_ptr_factory_.GetWeakPtr(),
       base::Passed(std::move(request)), match_params,
-      scheduler_->WrapCallbackToRunNext(callback)));
+      scheduler_->WrapCallbackToRunNext(std::move(callback))));
 }
 
-void CacheStorageCache::WriteSideData(const ErrorCallback& callback,
+void CacheStorageCache::WriteSideData(ErrorCallback callback,
                                       const GURL& url,
                                       base::Time expected_response_time,
                                       scoped_refptr<net::IOBuffer> buffer,
                                       int buf_len) {
   if (backend_state_ == BACKEND_CLOSED) {
     base::ThreadTaskRunnerHandle::Get()->PostTask(
-        FROM_HERE, base::Bind(callback, CACHE_STORAGE_ERROR_STORAGE));
+        FROM_HERE,
+        base::BindOnce(std::move(callback), CACHE_STORAGE_ERROR_STORAGE));
     return;
   }
 
   // GetUsageAndQuota is called before entering a scheduled operation since it
   // can call Size, another scheduled operation.
   quota_manager_proxy_->GetUsageAndQuota(
       base::ThreadTaskRunnerHandle::Get().get(), origin_,
       storage::kStorageTypeTemporary,
-      base::Bind(&CacheStorageCache::WriteSideDataDidGetQuota,
-                 weak_ptr_factory_.GetWeakPtr(), callback, url,
-                 expected_response_time, buffer, buf_len));
+      base::AdaptCallbackForRepeating(
+          base::BindOnce(&CacheStorageCache::WriteSideDataDidGetQuota,
+                         weak_ptr_factory_.GetWeakPtr(), std::move(callback),
+                         url, expected_response_time, buffer, buf_len)));
 }
 
 void CacheStorageCache::BatchOperation(
     const std::vector<CacheStorageBatchOperation>& operations,
-    const ErrorCallback& callback) {
+    ErrorCallback callback) {
   if (backend_state_ == BACKEND_CLOSED) {
     base::ThreadTaskRunnerHandle::Get()->PostTask(
-        FROM_HERE, base::Bind(callback, CACHE_STORAGE_ERROR_STORAGE));
+        FROM_HERE,
+        base::BindOnce(std::move(callback), CACHE_STORAGE_ERROR_STORAGE));
     return;
   }
 
   // Estimate the required size of the put operations. The size of the deletes
   // is unknown and not considered.
   int64_t space_required = 0;
   for (const auto& operation : operations) {
     if (operation.operation_type == CACHE_STORAGE_CACHE_OPERATION_TYPE_PUT) {
       space_required +=
           operation.request.blob_size + operation.response.blob_size;
     }
   }
   if (space_required > 0) {
     // GetUsageAndQuota is called before entering a scheduled operation since it
     // can call Size, another scheduled operation. This is racy. The decision
     // to commit is made before the scheduled Put operation runs. By the time
     // Put runs, the cache might already be full and the origin will be larger
     // than it's supposed to be.
     quota_manager_proxy_->GetUsageAndQuota(
         base::ThreadTaskRunnerHandle::Get().get(), origin_,
         storage::kStorageTypeTemporary,
-        base::Bind(&CacheStorageCache::BatchDidGetUsageAndQuota,
-                   weak_ptr_factory_.GetWeakPtr(), operations, callback,
-                   space_required));
+        base::AdaptCallbackForRepeating(
+            base::BindOnce(&CacheStorageCache::BatchDidGetUsageAndQuota,
+                           weak_ptr_factory_.GetWeakPtr(), operations,
+                           std::move(callback), space_required)));
     return;
   }
 
-  BatchDidGetUsageAndQuota(operations, callback, 0 /* space_required */,
-                           storage::kQuotaStatusOk, 0 /* usage */,
-                           0 /* quota */);
+  BatchDidGetUsageAndQuota(operations, std::move(callback),
+                           0 /* space_required */, storage::kQuotaStatusOk,
+                           0 /* usage */, 0 /* quota */);
 }
 
 void CacheStorageCache::BatchDidGetUsageAndQuota(
     const std::vector<CacheStorageBatchOperation>& operations,
-    const ErrorCallback& callback,
+    ErrorCallback callback,
     int64_t space_required,
     storage::QuotaStatusCode status_code,
     int64_t usage,
     int64_t quota) {
   if (status_code != storage::kQuotaStatusOk ||
       space_required > quota - usage) {
     base::ThreadTaskRunnerHandle::Get()->PostTask(
-        FROM_HERE, base::Bind(callback, CACHE_STORAGE_ERROR_QUOTA_EXCEEDED));
+        FROM_HERE, base::BindOnce(std::move(callback),
+                                  CACHE_STORAGE_ERROR_QUOTA_EXCEEDED));
     return;
   }
 
-  std::unique_ptr<ErrorCallback> callback_copy(new ErrorCallback(callback));
-  ErrorCallback* callback_ptr = callback_copy.get();
-  base::Closure barrier_closure = base::BarrierClosure(
-      operations.size(), base::Bind(&CacheStorageCache::BatchDidAllOperations,
-                                    weak_ptr_factory_.GetWeakPtr(),
-                                    base::Passed(std::move(callback_copy))));
-  ErrorCallback completion_callback =
-      base::Bind(&CacheStorageCache::BatchDidOneOperation,
-                 weak_ptr_factory_.GetWeakPtr(), barrier_closure, callback_ptr);
+  // The following relies on the guarantee that the RepeatingCallback returned
+  // from AdaptCallbackForRepeating invokes the original callback on the first
+  // invocation, and (critically) that subsequent invocations are ignored.
+  // TODO(jsbell): Replace AdaptCallbackForRepeating with ...? crbug.com/730593
+  auto callback_copy = base::AdaptCallbackForRepeating(std::move(callback));
+  auto barrier_closure = base::BarrierClosure(
+      operations.size(),
+      base::BindOnce(&CacheStorageCache::BatchDidAllOperations,
+                     weak_ptr_factory_.GetWeakPtr(), callback_copy));
+  auto completion_callback = base::BindRepeating(
+      &CacheStorageCache::BatchDidOneOperation, weak_ptr_factory_.GetWeakPtr(),
+      barrier_closure, callback_copy);
 
   for (const auto& operation : operations) {
     switch (operation.operation_type) {
       case CACHE_STORAGE_CACHE_OPERATION_TYPE_PUT:
         Put(operation, completion_callback);
         break;
       case CACHE_STORAGE_CACHE_OPERATION_TYPE_DELETE:
         DCHECK_EQ(1u, operations.size());
         Delete(operation, completion_callback);
         break;
       case CACHE_STORAGE_CACHE_OPERATION_TYPE_UNDEFINED:
         NOTREACHED();
         // TODO(nhiroki): This should return "TypeError".
         // http://crbug.com/425505
         completion_callback.Run(CACHE_STORAGE_ERROR_STORAGE);
         break;
     }
   }
 }
 
 void CacheStorageCache::BatchDidOneOperation(
-    const base::Closure& barrier_closure,
-    ErrorCallback* callback,
+    base::OnceClosure completion_closure,
+    ErrorCallback error_callback,
     CacheStorageError error) {
-  if (callback->is_null() || error == CACHE_STORAGE_OK) {
-    barrier_closure.Run();
-    return;
+  if (error != CACHE_STORAGE_OK) {
+    // This relies on |callback| being created by AdaptCallbackForRepeating
+    // and ignoring anything but the first invocation.
+    std::move(error_callback).Run(error);
   }
-  callback->Run(error);
-  callback->Reset();  // Only call the callback once.
 
-  barrier_closure.Run();
+  std::move(completion_closure).Run();
 }
 
-void CacheStorageCache::BatchDidAllOperations(
-    std::unique_ptr<ErrorCallback> callback) {
-  if (callback->is_null())
-    return;
-  callback->Run(CACHE_STORAGE_OK);
+void CacheStorageCache::BatchDidAllOperations(ErrorCallback callback) {
+  // This relies on |callback| being created by AdaptCallbackForRepeating
+  // and ignoring anything but the first invocation.
+  std::move(callback).Run(CACHE_STORAGE_OK);
 }
 
 void CacheStorageCache::Keys(std::unique_ptr<ServiceWorkerFetchRequest> request,
                              const CacheStorageCacheQueryParams& options,
-                             const RequestsCallback& callback) {
+                             RequestsCallback callback) {
   if (backend_state_ == BACKEND_CLOSED) {
-    callback.Run(CACHE_STORAGE_ERROR_STORAGE, std::unique_ptr<Requests>());
+    std::move(callback).Run(CACHE_STORAGE_ERROR_STORAGE,
+                            std::unique_ptr<Requests>());
     return;
   }
 
-  scheduler_->ScheduleOperation(
-      base::Bind(&CacheStorageCache::KeysImpl, weak_ptr_factory_.GetWeakPtr(),
-                 base::Passed(std::move(request)), options,
-                 scheduler_->WrapCallbackToRunNext(callback)));
+  scheduler_->ScheduleOperation(base::BindOnce(
+      &CacheStorageCache::KeysImpl, weak_ptr_factory_.GetWeakPtr(),
+      base::Passed(std::move(request)), options,
+      scheduler_->WrapCallbackToRunNext(std::move(callback))));
 }
 
-void CacheStorageCache::Close(const base::Closure& callback) {
+void CacheStorageCache::Close(base::OnceClosure callback) {
   DCHECK_NE(BACKEND_CLOSED, backend_state_)
       << "Was CacheStorageCache::Close() called twice?";
 
-  scheduler_->ScheduleOperation(
-      base::Bind(&CacheStorageCache::CloseImpl, weak_ptr_factory_.GetWeakPtr(),
-                 scheduler_->WrapCallbackToRunNext(callback)));
+  scheduler_->ScheduleOperation(base::BindOnce(
+      &CacheStorageCache::CloseImpl, weak_ptr_factory_.GetWeakPtr(),
+      scheduler_->WrapCallbackToRunNext(std::move(callback))));
 }
 
-void CacheStorageCache::Size(const SizeCallback& callback) {
+void CacheStorageCache::Size(SizeCallback callback) {
   if (backend_state_ == BACKEND_CLOSED) {
     // TODO(jkarlin): Delete caches that can't be initialized.
-    base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
-                                                  base::Bind(callback, 0));
+    base::ThreadTaskRunnerHandle::Get()->PostTask(
+        FROM_HERE, base::BindOnce(std::move(callback), 0));
     return;
   }
 
-  scheduler_->ScheduleOperation(
-      base::Bind(&CacheStorageCache::SizeImpl, weak_ptr_factory_.GetWeakPtr(),
-                 scheduler_->WrapCallbackToRunNext(callback)));
+  scheduler_->ScheduleOperation(base::BindOnce(
+      &CacheStorageCache::SizeImpl, weak_ptr_factory_.GetWeakPtr(),
+      scheduler_->WrapCallbackToRunNext(std::move(callback))));
 }
 
-void CacheStorageCache::GetSizeThenClose(const SizeCallback& callback) {
+void CacheStorageCache::GetSizeThenClose(SizeCallback callback) {
   if (backend_state_ == BACKEND_CLOSED) {
-    base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
-                                                  base::Bind(callback, 0));
+    base::ThreadTaskRunnerHandle::Get()->PostTask(
+        FROM_HERE, base::BindOnce(std::move(callback), 0));
     return;
   }
 
-  scheduler_->ScheduleOperation(
-      base::Bind(&CacheStorageCache::SizeImpl, weak_ptr_factory_.GetWeakPtr(),
-                 base::Bind(&CacheStorageCache::GetSizeThenCloseDidGetSize,
-                            weak_ptr_factory_.GetWeakPtr(),
-                            scheduler_->WrapCallbackToRunNext(callback))));
+  scheduler_->ScheduleOperation(base::BindOnce(
+      &CacheStorageCache::SizeImpl, weak_ptr_factory_.GetWeakPtr(),
+      base::BindOnce(&CacheStorageCache::GetSizeThenCloseDidGetSize,
+                     weak_ptr_factory_.GetWeakPtr(),
+                     scheduler_->WrapCallbackToRunNext(std::move(callback)))));
 }
 
 void CacheStorageCache::SetObserver(CacheStorageCacheObserver* observer) {
   DCHECK((observer == nullptr) ^ (cache_observer_ == nullptr));
   cache_observer_ = observer;
 }
 
 CacheStorageCache::~CacheStorageCache() {
   quota_manager_proxy_->NotifyOriginNoLongerInUse(origin_);
 }
@@ skipping 24 matching lines @@
   DCHECK(!origin_.is_empty());
   DCHECK(quota_manager_proxy_.get());
 
   quota_manager_proxy_->NotifyOriginInUse(origin_);
 }
 
 void CacheStorageCache::QueryCache(
     std::unique_ptr<ServiceWorkerFetchRequest> request,
     const CacheStorageCacheQueryParams& options,
     QueryCacheType query_type,
-    const QueryCacheCallback& callback) {
+    QueryCacheCallback callback) {
   DCHECK_NE(BACKEND_UNINITIALIZED, backend_state_);
   if (backend_state_ != BACKEND_OPEN) {
-    callback.Run(CACHE_STORAGE_ERROR_STORAGE,
-                 std::unique_ptr<QueryCacheResults>());
+    std::move(callback).Run(CACHE_STORAGE_ERROR_STORAGE,
+                            std::unique_ptr<QueryCacheResults>());
     return;
   }
 
   if (!options.ignore_method && request && !request->method.empty() &&
       request->method != "GET") {
-    callback.Run(CACHE_STORAGE_OK, base::MakeUnique<QueryCacheResults>());
+    std::move(callback).Run(CACHE_STORAGE_OK,
+                            base::MakeUnique<QueryCacheResults>());
     return;
   }
 
   ServiceWorkerFetchRequest* request_ptr = request.get();
   std::unique_ptr<QueryCacheContext> query_cache_context(
-      new QueryCacheContext(std::move(request), options, callback));
+      new QueryCacheContext(std::move(request), options, std::move(callback)));
   query_cache_context->query_type = query_type;
 
   if (query_cache_context->request &&
       !query_cache_context->request->url.is_empty() && !options.ignore_search) {
     // There is no need to scan the entire backend, just open the exact
     // URL.
     disk_cache::Entry** entry_ptr = &query_cache_context->enumerated_entry;
     net::CompletionCallback open_entry_callback =
-        base::Bind(&CacheStorageCache::QueryCacheDidOpenFastPath,
-                   weak_ptr_factory_.GetWeakPtr(),
-                   base::Passed(std::move(query_cache_context)));
+        base::AdaptCallbackForRepeating(
+            base::BindOnce(&CacheStorageCache::QueryCacheDidOpenFastPath,
+                           weak_ptr_factory_.GetWeakPtr(),
+                           base::Passed(std::move(query_cache_context))));
     int rv = backend_->OpenEntry(request_ptr->url.spec(), entry_ptr,
                                  open_entry_callback);
     if (rv != net::ERR_IO_PENDING)
       open_entry_callback.Run(rv);
     return;
   }
 
   query_cache_context->backend_iterator = backend_->CreateIterator();
   QueryCacheOpenNextEntry(std::move(query_cache_context));
 }
 
 void CacheStorageCache::QueryCacheDidOpenFastPath(
     std::unique_ptr<QueryCacheContext> query_cache_context,
     int rv) {
   if (rv != net::OK) {
     QueryCacheContext* results = query_cache_context.get();
-    results->callback.Run(CACHE_STORAGE_OK,
-                          std::move(query_cache_context->matches));
+    std::move(results->callback)
+        .Run(CACHE_STORAGE_OK, std::move(query_cache_context->matches));
     return;
   }
   QueryCacheFilterEntry(std::move(query_cache_context), rv);
 }
 
 void CacheStorageCache::QueryCacheOpenNextEntry(
     std::unique_ptr<QueryCacheContext> query_cache_context) {
   DCHECK_EQ(nullptr, query_cache_context->enumerated_entry);
 
   if (!query_cache_context->backend_iterator) {
     // Iteration is complete.
     std::sort(query_cache_context->matches->begin(),
               query_cache_context->matches->end(), QueryCacheResultCompare);
 
-    query_cache_context->callback.Run(CACHE_STORAGE_OK,
-                                      std::move(query_cache_context->matches));
+    std::move(query_cache_context->callback)
+        .Run(CACHE_STORAGE_OK, std::move(query_cache_context->matches));
     return;
   }
 
   disk_cache::Backend::Iterator& iterator =
       *query_cache_context->backend_iterator;
   disk_cache::Entry** enumerated_entry = &query_cache_context->enumerated_entry;
-  net::CompletionCallback open_entry_callback = base::Bind(
-      &CacheStorageCache::QueryCacheFilterEntry, weak_ptr_factory_.GetWeakPtr(),
-      base::Passed(std::move(query_cache_context)));
+  net::CompletionCallback open_entry_callback = base::AdaptCallbackForRepeating(
+      base::BindOnce(&CacheStorageCache::QueryCacheFilterEntry,
+                     weak_ptr_factory_.GetWeakPtr(),
+                     base::Passed(std::move(query_cache_context))));
 
   int rv = iterator.OpenNextEntry(enumerated_entry, open_entry_callback);
 
   if (rv != net::ERR_IO_PENDING)
     open_entry_callback.Run(rv);
 }
 
 void CacheStorageCache::QueryCacheFilterEntry(
     std::unique_ptr<QueryCacheContext> query_cache_context,
     int rv) {
   if (rv == net::ERR_FAILED) {
     // This is the indicator that iteration is complete.
     query_cache_context->backend_iterator.reset();
     QueryCacheOpenNextEntry(std::move(query_cache_context));
     return;
   }
 
   if (rv < 0) {
-    QueryCacheCallback callback = query_cache_context->callback;
-    callback.Run(CACHE_STORAGE_ERROR_STORAGE,
-                 std::move(query_cache_context->matches));
+    std::move(query_cache_context->callback)
+        .Run(CACHE_STORAGE_ERROR_STORAGE,
+             std::move(query_cache_context->matches));
     return;
   }
 
   disk_cache::ScopedEntryPtr entry(query_cache_context->enumerated_entry);
   query_cache_context->enumerated_entry = nullptr;
 
   if (backend_state_ != BACKEND_OPEN) {
-    QueryCacheCallback callback = query_cache_context->callback;
-    callback.Run(CACHE_STORAGE_ERROR_NOT_FOUND,
-                 std::move(query_cache_context->matches));
+    std::move(query_cache_context->callback)
+        .Run(CACHE_STORAGE_ERROR_NOT_FOUND,
+             std::move(query_cache_context->matches));
     return;
   }
 
   if (query_cache_context->request &&
       !query_cache_context->request->url.is_empty()) {
     GURL requestURL = query_cache_context->request->url;
     GURL cachedURL = GURL(entry->GetKey());
 
     if (query_cache_context->options.ignore_search) {
       requestURL = RemoveQueryParam(requestURL);
       cachedURL = RemoveQueryParam(cachedURL);
     }
 
     if (cachedURL != requestURL) {
       QueryCacheOpenNextEntry(std::move(query_cache_context));
       return;
     }
   }
 
   disk_cache::Entry* entry_ptr = entry.get();
   ReadMetadata(entry_ptr,
-               base::Bind(&CacheStorageCache::QueryCacheDidReadMetadata,
-                          weak_ptr_factory_.GetWeakPtr(),
-                          base::Passed(std::move(query_cache_context)),
-                          base::Passed(std::move(entry))));
+               base::BindOnce(&CacheStorageCache::QueryCacheDidReadMetadata,
+                              weak_ptr_factory_.GetWeakPtr(),
+                              base::Passed(std::move(query_cache_context)),
+                              base::Passed(std::move(entry))));
 }
 
 void CacheStorageCache::QueryCacheDidReadMetadata(
     std::unique_ptr<QueryCacheContext> query_cache_context,
     disk_cache::ScopedEntryPtr entry,
     std::unique_ptr<proto::CacheMetadata> metadata) {
   if (!metadata) {
     entry->Doom();
     QueryCacheOpenNextEntry(std::move(query_cache_context));
     return;
@@ skipping 24 matching lines @@
     match->request.reset();
     match->response.reset();
     match->entry = std::move(entry);
     QueryCacheOpenNextEntry(std::move(query_cache_context));
     return;
   }
 
   query_cache_context->estimated_out_bytes +=
       match->request->EstimatedStructSize();
   if (query_cache_context->estimated_out_bytes > max_query_size_bytes_) {
-    query_cache_context->callback.Run(CACHE_STORAGE_ERROR_QUERY_TOO_LARGE,
-                                      std::unique_ptr<QueryCacheResults>());
+    std::move(query_cache_context->callback)
+        .Run(CACHE_STORAGE_ERROR_QUERY_TOO_LARGE,
+             std::unique_ptr<QueryCacheResults>());
     return;
   }
 
   if (query_cache_context->query_type == QueryCacheType::REQUESTS) {
     match->response.reset();
     QueryCacheOpenNextEntry(std::move(query_cache_context));
     return;
   }
 
   DCHECK_EQ(QueryCacheType::REQUESTS_AND_RESPONSES,
             query_cache_context->query_type);
 
   query_cache_context->estimated_out_bytes +=
       match->response->EstimatedStructSize();
   if (query_cache_context->estimated_out_bytes > max_query_size_bytes_) {
-    query_cache_context->callback.Run(CACHE_STORAGE_ERROR_QUERY_TOO_LARGE,
-                                      std::unique_ptr<QueryCacheResults>());
+    std::move(query_cache_context->callback)
+        .Run(CACHE_STORAGE_ERROR_QUERY_TOO_LARGE,
+             std::unique_ptr<QueryCacheResults>());
     return;
   }
 
   if (entry->GetDataSize(INDEX_RESPONSE_BODY) == 0) {
     QueryCacheOpenNextEntry(std::move(query_cache_context));
     return;
   }
 
   if (!blob_storage_context_) {
-    query_cache_context->callback.Run(CACHE_STORAGE_ERROR_STORAGE,
-                                      base::MakeUnique<QueryCacheResults>());
+    std::move(query_cache_context->callback)
+        .Run(CACHE_STORAGE_ERROR_STORAGE,
+             base::MakeUnique<QueryCacheResults>());
     return;
   }
 
   std::unique_ptr<storage::BlobDataHandle> blob_data_handle =
       PopulateResponseBody(std::move(entry), match->response.get());
   match->blob_handle = std::move(blob_data_handle);
 
   QueryCacheOpenNextEntry(std::move(query_cache_context));
 }
 
 // static
 bool CacheStorageCache::QueryCacheResultCompare(const QueryCacheResult& lhs,
                                                 const QueryCacheResult& rhs) {
   return lhs.entry_time < rhs.entry_time;
 }
 
 void CacheStorageCache::MatchImpl(
     std::unique_ptr<ServiceWorkerFetchRequest> request,
     const CacheStorageCacheQueryParams& match_params,
-    const ResponseCallback& callback) {
-  MatchAllImpl(std::move(request), match_params,
-               base::Bind(&CacheStorageCache::MatchDidMatchAll,
-                          weak_ptr_factory_.GetWeakPtr(), callback));
+    ResponseCallback callback) {
+  MatchAllImpl(
+      std::move(request), match_params,
+      base::BindOnce(&CacheStorageCache::MatchDidMatchAll,
+                     weak_ptr_factory_.GetWeakPtr(), std::move(callback)));
 }
 
 void CacheStorageCache::MatchDidMatchAll(
-    const ResponseCallback& callback,
+    ResponseCallback callback,
     CacheStorageError match_all_error,
     std::unique_ptr<Responses> match_all_responses,
     std::unique_ptr<BlobDataHandles> match_all_handles) {
   if (match_all_error != CACHE_STORAGE_OK) {
-    callback.Run(match_all_error, std::unique_ptr<ServiceWorkerResponse>(),
-                 std::unique_ptr<storage::BlobDataHandle>());
+    std::move(callback).Run(match_all_error,
+                            std::unique_ptr<ServiceWorkerResponse>(),
+                            std::unique_ptr<storage::BlobDataHandle>());
     return;
   }
 
   if (match_all_responses->empty()) {
-    callback.Run(CACHE_STORAGE_ERROR_NOT_FOUND,
-                 std::unique_ptr<ServiceWorkerResponse>(),
-                 std::unique_ptr<storage::BlobDataHandle>());
+    std::move(callback).Run(CACHE_STORAGE_ERROR_NOT_FOUND,
+                            std::unique_ptr<ServiceWorkerResponse>(),
+                            std::unique_ptr<storage::BlobDataHandle>());
     return;
   }
 
   std::unique_ptr<ServiceWorkerResponse> response =
       base::MakeUnique<ServiceWorkerResponse>(match_all_responses->at(0));
 
-  callback.Run(CACHE_STORAGE_OK, std::move(response),
-               std::move(match_all_handles->at(0)));
+  std::move(callback).Run(CACHE_STORAGE_OK, std::move(response),
+                          std::move(match_all_handles->at(0)));
 }
 
 void CacheStorageCache::MatchAllImpl(
     std::unique_ptr<ServiceWorkerFetchRequest> request,
     const CacheStorageCacheQueryParams& options,
-    const ResponsesCallback& callback) {
+    ResponsesCallback callback) {
   DCHECK_NE(BACKEND_UNINITIALIZED, backend_state_);
   if (backend_state_ != BACKEND_OPEN) {
-    callback.Run(CACHE_STORAGE_ERROR_STORAGE, std::unique_ptr<Responses>(),
-                 std::unique_ptr<BlobDataHandles>());
+    std::move(callback).Run(CACHE_STORAGE_ERROR_STORAGE,
+                            std::unique_ptr<Responses>(),
+                            std::unique_ptr<BlobDataHandles>());
     return;
   }
 
-  QueryCache(std::move(request), options,
-             QueryCacheType::REQUESTS_AND_RESPONSES,
-             base::Bind(&CacheStorageCache::MatchAllDidQueryCache,
-                        weak_ptr_factory_.GetWeakPtr(), callback));
+  QueryCache(
+      std::move(request), options, QueryCacheType::REQUESTS_AND_RESPONSES,
+      base::BindOnce(&CacheStorageCache::MatchAllDidQueryCache,
+                     weak_ptr_factory_.GetWeakPtr(), std::move(callback)));
 }
 
 void CacheStorageCache::MatchAllDidQueryCache(
-    const ResponsesCallback& callback,
+    ResponsesCallback callback,
     CacheStorageError error,
     std::unique_ptr<QueryCacheResults> query_cache_results) {
   if (error != CACHE_STORAGE_OK) {
-    callback.Run(error, std::unique_ptr<Responses>(),
-                 std::unique_ptr<BlobDataHandles>());
+    std::move(callback).Run(error, std::unique_ptr<Responses>(),
+                            std::unique_ptr<BlobDataHandles>());
     return;
   }
 
   std::unique_ptr<Responses> out_responses = base::MakeUnique<Responses>();
   std::unique_ptr<BlobDataHandles> out_handles =
       base::MakeUnique<BlobDataHandles>();
   out_responses->reserve(query_cache_results->size());
   out_handles->reserve(query_cache_results->size());
 
   for (auto& result : *query_cache_results) {
     out_responses->push_back(*result.response);
     out_handles->push_back(std::move(result.blob_handle));
   }
 
-  callback.Run(CACHE_STORAGE_OK, std::move(out_responses),
-               std::move(out_handles));
+  std::move(callback).Run(CACHE_STORAGE_OK, std::move(out_responses),
+                          std::move(out_handles));
 }
 
 void CacheStorageCache::WriteSideDataDidGetQuota(
-    const ErrorCallback& callback,
+    ErrorCallback callback,
     const GURL& url,
     base::Time expected_response_time,
     scoped_refptr<net::IOBuffer> buffer,
     int buf_len,
     storage::QuotaStatusCode status_code,
     int64_t usage,
     int64_t quota) {
   if (status_code != storage::kQuotaStatusOk || (buf_len > quota - usage)) {
     base::ThreadTaskRunnerHandle::Get()->PostTask(
-        FROM_HERE, base::Bind(callback, CACHE_STORAGE_ERROR_QUOTA_EXCEEDED));
+        FROM_HERE, base::BindOnce(std::move(callback),
+                                  CACHE_STORAGE_ERROR_QUOTA_EXCEEDED));
     return;
   }
 
-  scheduler_->ScheduleOperation(base::Bind(
+  scheduler_->ScheduleOperation(base::BindOnce(
       &CacheStorageCache::WriteSideDataImpl, weak_ptr_factory_.GetWeakPtr(),
-      scheduler_->WrapCallbackToRunNext(callback), url, expected_response_time,
-      buffer, buf_len));
+      scheduler_->WrapCallbackToRunNext(std::move(callback)), url,
+      expected_response_time, buffer, buf_len));
 }
 
-void CacheStorageCache::WriteSideDataImpl(const ErrorCallback& callback,
+void CacheStorageCache::WriteSideDataImpl(ErrorCallback callback,
                                           const GURL& url,
                                           base::Time expected_response_time,
                                           scoped_refptr<net::IOBuffer> buffer,
                                           int buf_len) {
   DCHECK_NE(BACKEND_UNINITIALIZED, backend_state_);
   if (backend_state_ != BACKEND_OPEN) {
-    callback.Run(CACHE_STORAGE_ERROR_STORAGE);
+    std::move(callback).Run(CACHE_STORAGE_ERROR_STORAGE);
     return;
   }
 
   std::unique_ptr<disk_cache::Entry*> scoped_entry_ptr(
       new disk_cache::Entry*());
   disk_cache::Entry** entry_ptr = scoped_entry_ptr.get();
-  net::CompletionCallback open_entry_callback = base::Bind(
-      &CacheStorageCache::WriteSideDataDidOpenEntry,
-      weak_ptr_factory_.GetWeakPtr(), callback, expected_response_time, buffer,
-      buf_len, base::Passed(std::move(scoped_entry_ptr)));
+  net::CompletionCallback open_entry_callback = base::AdaptCallbackForRepeating(
+      base::BindOnce(&CacheStorageCache::WriteSideDataDidOpenEntry,
+                     weak_ptr_factory_.GetWeakPtr(), std::move(callback),
+                     expected_response_time, buffer, buf_len,
+                     base::Passed(std::move(scoped_entry_ptr))));
 
   int rv = backend_->OpenEntry(url.spec(), entry_ptr, open_entry_callback);
   if (rv != net::ERR_IO_PENDING)
     open_entry_callback.Run(rv);
 }
 
 void CacheStorageCache::WriteSideDataDidOpenEntry(
-    const ErrorCallback& callback,
+    ErrorCallback callback,
     base::Time expected_response_time,
     scoped_refptr<net::IOBuffer> buffer,
     int buf_len,
     std::unique_ptr<disk_cache::Entry*> entry_ptr,
     int rv) {
   if (rv != net::OK) {
-    callback.Run(CACHE_STORAGE_ERROR_NOT_FOUND);
+    std::move(callback).Run(CACHE_STORAGE_ERROR_NOT_FOUND);
     return;
   }
   disk_cache::ScopedEntryPtr entry(*entry_ptr);
 
   ReadMetadata(*entry_ptr,
-               base::Bind(&CacheStorageCache::WriteSideDataDidReadMetaData,
-                          weak_ptr_factory_.GetWeakPtr(), callback,
-                          expected_response_time, buffer, buf_len,
-                          base::Passed(std::move(entry))));
+               base::BindOnce(&CacheStorageCache::WriteSideDataDidReadMetaData,
+                              weak_ptr_factory_.GetWeakPtr(),
+                              std::move(callback), expected_response_time,
+                              buffer, buf_len, base::Passed(std::move(entry))));
 }
 
 void CacheStorageCache::WriteSideDataDidReadMetaData(
-    const ErrorCallback& callback,
+    ErrorCallback callback,
     base::Time expected_response_time,
     scoped_refptr<net::IOBuffer> buffer,
     int buf_len,
     disk_cache::ScopedEntryPtr entry,
     std::unique_ptr<proto::CacheMetadata> headers) {
   if (!headers ||
       headers->response().response_time() !=
           expected_response_time.ToInternalValue()) {
-    callback.Run(CACHE_STORAGE_ERROR_NOT_FOUND);
+    std::move(callback).Run(CACHE_STORAGE_ERROR_NOT_FOUND);
     return;
   }
   // Get a temporary copy of the entry pointer before passing it in base::Bind.
   disk_cache::Entry* temp_entry_ptr = entry.get();
 
-  net::CompletionCallback write_side_data_callback = base::Bind(
-      &CacheStorageCache::WriteSideDataDidWrite, weak_ptr_factory_.GetWeakPtr(),
-      callback, base::Passed(std::move(entry)), buf_len);
+  net::CompletionCallback write_side_data_callback =
+      base::AdaptCallbackForRepeating(
+          base::BindOnce(&CacheStorageCache::WriteSideDataDidWrite,
+                         weak_ptr_factory_.GetWeakPtr(), std::move(callback),
+                         base::Passed(std::move(entry)), buf_len));
 
   int rv = temp_entry_ptr->WriteData(
       INDEX_SIDE_DATA, 0 /* offset */, buffer.get(), buf_len,
       write_side_data_callback, true /* truncate */);
 
   if (rv != net::ERR_IO_PENDING)
     write_side_data_callback.Run(rv);
 }
 
-void CacheStorageCache::WriteSideDataDidWrite(const ErrorCallback& callback,
+void CacheStorageCache::WriteSideDataDidWrite(ErrorCallback callback,
                                               disk_cache::ScopedEntryPtr entry,
                                               int expected_bytes,
                                               int rv) {
   if (rv != expected_bytes) {
     entry->Doom();
-    UpdateCacheSize(base::Bind(callback, CACHE_STORAGE_ERROR_NOT_FOUND));
+    UpdateCacheSize(
+        base::BindOnce(std::move(callback), CACHE_STORAGE_ERROR_NOT_FOUND));
     return;
   }
 
   if (rv > 0)
     storage::RecordBytesWritten(kRecordBytesLabel, rv);
 
-  UpdateCacheSize(base::Bind(callback, CACHE_STORAGE_OK));
+  UpdateCacheSize(base::BindOnce(std::move(callback), CACHE_STORAGE_OK));
 }
 
 void CacheStorageCache::Put(const CacheStorageBatchOperation& operation,
-                            const ErrorCallback& callback) {
+                            ErrorCallback callback) {
   DCHECK(BACKEND_OPEN == backend_state_ || initializing_);
   DCHECK_EQ(CACHE_STORAGE_CACHE_OPERATION_TYPE_PUT, operation.operation_type);
 
   std::unique_ptr<ServiceWorkerFetchRequest> request(
       new ServiceWorkerFetchRequest(
           operation.request.url, operation.request.method,
           operation.request.headers, operation.request.referrer,
           operation.request.is_reload));
 
   std::unique_ptr<ServiceWorkerResponse> response =
       base::MakeUnique<ServiceWorkerResponse>(operation.response);
   std::unique_ptr<storage::BlobDataHandle> blob_data_handle;
 
   if (!response->blob_uuid.empty()) {
     if (!blob_storage_context_) {
-      callback.Run(CACHE_STORAGE_ERROR_STORAGE);
+      std::move(callback).Run(CACHE_STORAGE_ERROR_STORAGE);
       return;
     }
     blob_data_handle =
         blob_storage_context_->GetBlobDataFromUUID(response->blob_uuid);
     if (!blob_data_handle) {
-      callback.Run(CACHE_STORAGE_ERROR_STORAGE);
+      std::move(callback).Run(CACHE_STORAGE_ERROR_STORAGE);
       return;
     }
   }
 
   UMA_HISTOGRAM_ENUMERATION(
       "ServiceWorkerCache.Cache.AllWritesResponseType",
       operation.response.response_type,
       blink::WebServiceWorkerResponseType::kWebServiceWorkerResponseTypeLast +
           1);
 
   std::unique_ptr<PutContext> put_context(new PutContext(
       std::move(request), std::move(response), std::move(blob_data_handle),
-      scheduler_->WrapCallbackToRunNext(callback)));
+      scheduler_->WrapCallbackToRunNext(std::move(callback))));
 
-  scheduler_->ScheduleOperation(
-      base::Bind(&CacheStorageCache::PutImpl, weak_ptr_factory_.GetWeakPtr(),
-                 base::Passed(std::move(put_context))));
+  scheduler_->ScheduleOperation(base::BindOnce(
+      &CacheStorageCache::PutImpl, weak_ptr_factory_.GetWeakPtr(),
+      base::Passed(std::move(put_context))));
 }
 
 void CacheStorageCache::PutImpl(std::unique_ptr<PutContext> put_context) {
   DCHECK_NE(BACKEND_UNINITIALIZED, backend_state_);
   if (backend_state_ != BACKEND_OPEN) {
-    put_context->callback.Run(CACHE_STORAGE_ERROR_STORAGE);
+    std::move(put_context->callback).Run(CACHE_STORAGE_ERROR_STORAGE);
     return;
   }
 
   std::string key = put_context->request->url.spec();
 
-  net::CompletionCallback callback = base::Bind(
-      &CacheStorageCache::PutDidDoomEntry, weak_ptr_factory_.GetWeakPtr(),
-      base::Passed(std::move(put_context)));
+  net::CompletionCallback callback =
+      base::AdaptCallbackForRepeating(base::BindOnce(
+          &CacheStorageCache::PutDidDoomEntry, weak_ptr_factory_.GetWeakPtr(),
+          base::Passed(std::move(put_context))));
 
   int rv = backend_->DoomEntry(key, callback);
   if (rv != net::ERR_IO_PENDING)
     callback.Run(rv);
 }
 
 void CacheStorageCache::PutDidDoomEntry(std::unique_ptr<PutContext> put_context,
                                         int rv) {
   if (backend_state_ != BACKEND_OPEN) {
-    put_context->callback.Run(CACHE_STORAGE_ERROR_STORAGE);
+    std::move(put_context->callback).Run(CACHE_STORAGE_ERROR_STORAGE);
     return;
   }
 
   // |rv| is ignored as doom entry can fail if the entry doesn't exist.
 
   std::unique_ptr<disk_cache::Entry*> scoped_entry_ptr(
       new disk_cache::Entry*());
   disk_cache::Entry** entry_ptr = scoped_entry_ptr.get();
   ServiceWorkerFetchRequest* request_ptr = put_context->request.get();
   disk_cache::Backend* backend_ptr = backend_.get();
 
-  net::CompletionCallback create_entry_callback = base::Bind(
-      &CacheStorageCache::PutDidCreateEntry, weak_ptr_factory_.GetWeakPtr(),
-      base::Passed(std::move(scoped_entry_ptr)),
-      base::Passed(std::move(put_context)));
+  net::CompletionCallback create_entry_callback =
+      base::AdaptCallbackForRepeating(base::BindOnce(
+          &CacheStorageCache::PutDidCreateEntry, weak_ptr_factory_.GetWeakPtr(),
+          base::Passed(std::move(scoped_entry_ptr)),
+          base::Passed(std::move(put_context))));
 
   int create_rv = backend_ptr->CreateEntry(request_ptr->url.spec(), entry_ptr,
                                            create_entry_callback);
 
   if (create_rv != net::ERR_IO_PENDING)
     create_entry_callback.Run(create_rv);
 }
 
 void CacheStorageCache::PutDidCreateEntry(
     std::unique_ptr<disk_cache::Entry*> entry_ptr,
     std::unique_ptr<PutContext> put_context,
     int rv) {
   put_context->cache_entry.reset(*entry_ptr);
 
   if (rv != net::OK) {
-    put_context->callback.Run(CACHE_STORAGE_ERROR_EXISTS);
+    std::move(put_context->callback).Run(CACHE_STORAGE_ERROR_EXISTS);
     return;
   }
 
   proto::CacheMetadata metadata;
   metadata.set_entry_time(base::Time::Now().ToInternalValue());
   proto::CacheRequest* request_metadata = metadata.mutable_request();
   request_metadata->set_method(put_context->request->method);
   for (ServiceWorkerHeaderMap::const_iterator it =
            put_context->request->headers.begin();
        it != put_context->request->headers.end(); ++it) {
@@ skipping 20 matching lines @@
     DCHECK_EQ(std::string::npos, it->second.find('\0'));
     proto::CacheHeaderMap* header_map = response_metadata->add_headers();
     header_map->set_name(it->first);
     header_map->set_value(it->second);
   }
   for (const auto& header : put_context->response->cors_exposed_header_names)
     response_metadata->add_cors_exposed_header_names(header);
 
   std::unique_ptr<std::string> serialized(new std::string());
   if (!metadata.SerializeToString(serialized.get())) {
-    put_context->callback.Run(CACHE_STORAGE_ERROR_STORAGE);
+    std::move(put_context->callback).Run(CACHE_STORAGE_ERROR_STORAGE);
     return;
   }
 
   scoped_refptr<net::StringIOBuffer> buffer(
       new net::StringIOBuffer(std::move(serialized)));
 
   // Get a temporary copy of the entry pointer before passing it in base::Bind.
   disk_cache::Entry* temp_entry_ptr = put_context->cache_entry.get();
 
-  net::CompletionCallback write_headers_callback = base::Bind(
-      &CacheStorageCache::PutDidWriteHeaders, weak_ptr_factory_.GetWeakPtr(),
-      base::Passed(std::move(put_context)), buffer->size());
+  net::CompletionCallback write_headers_callback =
+      base::AdaptCallbackForRepeating(
+          base::BindOnce(&CacheStorageCache::PutDidWriteHeaders,
+                         weak_ptr_factory_.GetWeakPtr(),
+                         base::Passed(std::move(put_context)), buffer->size()));
 
   rv = temp_entry_ptr->WriteData(INDEX_HEADERS, 0 /* offset */, buffer.get(),
                                  buffer->size(), write_headers_callback,
                                  true /* truncate */);
 
   if (rv != net::ERR_IO_PENDING)
     write_headers_callback.Run(rv);
 }
 
 void CacheStorageCache::PutDidWriteHeaders(
     std::unique_ptr<PutContext> put_context,
     int expected_bytes,
     int rv) {
   if (rv != expected_bytes) {
     put_context->cache_entry->Doom();
-    put_context->callback.Run(CACHE_STORAGE_ERROR_STORAGE);
+    std::move(put_context->callback).Run(CACHE_STORAGE_ERROR_STORAGE);
     return;
   }
 
   if (rv > 0)
     storage::RecordBytesWritten(kRecordBytesLabel, rv);
 
   // The metadata is written, now for the response content. The data is streamed
   // from the blob into the cache entry.
 
   if (put_context->response->blob_uuid.empty()) {
-    UpdateCacheSize(base::Bind(put_context->callback, CACHE_STORAGE_OK));
+    UpdateCacheSize(
+        base::BindOnce(std::move(put_context->callback), CACHE_STORAGE_OK));
     return;
   }
 
   DCHECK(put_context->blob_data_handle);
 
   disk_cache::ScopedEntryPtr entry(std::move(put_context->cache_entry));
   put_context->cache_entry = NULL;
 
   auto blob_to_cache = base::MakeUnique<CacheStorageBlobToDiskCache>();
   CacheStorageBlobToDiskCache* blob_to_cache_raw = blob_to_cache.get();
   BlobToDiskCacheIDMap::KeyType blob_to_cache_key =
       active_blob_to_disk_cache_writers_.Add(std::move(blob_to_cache));
 
   std::unique_ptr<storage::BlobDataHandle> blob_data_handle =
       std::move(put_context->blob_data_handle);
 
   blob_to_cache_raw->StreamBlobToCache(
       std::move(entry), INDEX_RESPONSE_BODY, request_context_getter_.get(),
       std::move(blob_data_handle),
-      base::Bind(&CacheStorageCache::PutDidWriteBlobToCache,
-                 weak_ptr_factory_.GetWeakPtr(),
-                 base::Passed(std::move(put_context)), blob_to_cache_key));
+      base::BindOnce(&CacheStorageCache::PutDidWriteBlobToCache,
+                     weak_ptr_factory_.GetWeakPtr(),
+                     base::Passed(std::move(put_context)), blob_to_cache_key));
 }
 
 void CacheStorageCache::PutDidWriteBlobToCache(
     std::unique_ptr<PutContext> put_context,
     BlobToDiskCacheIDMap::KeyType blob_to_cache_key,
     disk_cache::ScopedEntryPtr entry,
     bool success) {
   DCHECK(entry);
   put_context->cache_entry = std::move(entry);
 
   active_blob_to_disk_cache_writers_.Remove(blob_to_cache_key);
 
   if (!success) {
     put_context->cache_entry->Doom();
-    put_context->callback.Run(CACHE_STORAGE_ERROR_STORAGE);
+    std::move(put_context->callback).Run(CACHE_STORAGE_ERROR_STORAGE);
     return;
   }
 
-  UpdateCacheSize(base::Bind(put_context->callback, CACHE_STORAGE_OK));
+  UpdateCacheSize(
+      base::BindOnce(std::move(put_context->callback), CACHE_STORAGE_OK));
 }
 
-void CacheStorageCache::UpdateCacheSize(const base::Closure& callback) {
+void CacheStorageCache::UpdateCacheSize(base::OnceClosure callback) {
   if (backend_state_ != BACKEND_OPEN)
     return;
 
   // Note that the callback holds a cache handle to keep the cache alive during
   // the operation since this UpdateCacheSize is often run after an operation
   // completes and runs its callback.
-  int rv = backend_->CalculateSizeOfAllEntries(
-      base::Bind(&CacheStorageCache::UpdateCacheSizeGotSize,
-                 weak_ptr_factory_.GetWeakPtr(),
-                 base::Passed(CreateCacheHandle()), callback));
+  net::CompletionCallback size_callback = base::AdaptCallbackForRepeating(
+      base::BindOnce(&CacheStorageCache::UpdateCacheSizeGotSize,
+                     weak_ptr_factory_.GetWeakPtr(),
+                     base::Passed(CreateCacheHandle()), std::move(callback)));
 
+  int rv = backend_->CalculateSizeOfAllEntries(size_callback);
   if (rv != net::ERR_IO_PENDING)
-    UpdateCacheSizeGotSize(CreateCacheHandle(), callback, rv);
+    std::move(size_callback).Run(rv);
 }
 
 void CacheStorageCache::UpdateCacheSizeGotSize(
     std::unique_ptr<CacheStorageCacheHandle> cache_handle,
-    const base::Closure& callback,
+    base::OnceClosure callback,
     int current_cache_size) {
   DCHECK_NE(current_cache_size, CacheStorage::kSizeUnknown);
   int64_t old_cache_size = cache_size_;
   cache_size_ = current_cache_size;
 
   int64_t size_delta = current_cache_size - old_cache_size;
 
   quota_manager_proxy_->NotifyStorageModified(
       storage::QuotaClient::kServiceWorkerCache, origin_,
       storage::kStorageTypeTemporary, size_delta);
 
   if (cache_observer_)
     cache_observer_->CacheSizeUpdated(this, current_cache_size);
 
-  callback.Run();
+  std::move(callback).Run();
 }
 
 void CacheStorageCache::Delete(const CacheStorageBatchOperation& operation,
-                               const ErrorCallback& callback) {
+                               ErrorCallback callback) {
   DCHECK(BACKEND_OPEN == backend_state_ || initializing_);
   DCHECK_EQ(CACHE_STORAGE_CACHE_OPERATION_TYPE_DELETE,
             operation.operation_type);
 
   std::unique_ptr<ServiceWorkerFetchRequest> request(
       new ServiceWorkerFetchRequest(
           operation.request.url, operation.request.method,
           operation.request.headers, operation.request.referrer,
           operation.request.is_reload));
 
-  scheduler_->ScheduleOperation(
-      base::Bind(&CacheStorageCache::DeleteImpl, weak_ptr_factory_.GetWeakPtr(),
-                 base::Passed(std::move(request)), operation.match_params,
-                 scheduler_->WrapCallbackToRunNext(callback)));
+  scheduler_->ScheduleOperation(base::BindOnce(
+      &CacheStorageCache::DeleteImpl, weak_ptr_factory_.GetWeakPtr(),
+      base::Passed(std::move(request)), operation.match_params,
+      scheduler_->WrapCallbackToRunNext(std::move(callback))));
 }
 
 void CacheStorageCache::DeleteImpl(
     std::unique_ptr<ServiceWorkerFetchRequest> request,
     const CacheStorageCacheQueryParams& match_params,
-    const ErrorCallback& callback) {
+    ErrorCallback callback) {
   DCHECK_NE(BACKEND_UNINITIALIZED, backend_state_);
   if (backend_state_ != BACKEND_OPEN) {
-    callback.Run(CACHE_STORAGE_ERROR_STORAGE);
+    std::move(callback).Run(CACHE_STORAGE_ERROR_STORAGE);
     return;
   }
 
-  QueryCache(std::move(request), match_params, QueryCacheType::CACHE_ENTRIES,
-             base::Bind(&CacheStorageCache::DeleteDidQueryCache,
-                        weak_ptr_factory_.GetWeakPtr(), callback));
+  QueryCache(
+      std::move(request), match_params, QueryCacheType::CACHE_ENTRIES,
+      base::BindOnce(&CacheStorageCache::DeleteDidQueryCache,
+                     weak_ptr_factory_.GetWeakPtr(), std::move(callback)));
 }
 
 void CacheStorageCache::DeleteDidQueryCache(
-    const ErrorCallback& callback,
+    ErrorCallback callback,
     CacheStorageError error,
     std::unique_ptr<QueryCacheResults> query_cache_results) {
   if (error != CACHE_STORAGE_OK) {
-    callback.Run(error);
+    std::move(callback).Run(error);
     return;
   }
 
   if (query_cache_results->empty()) {
-    callback.Run(CACHE_STORAGE_ERROR_NOT_FOUND);
+    std::move(callback).Run(CACHE_STORAGE_ERROR_NOT_FOUND);
     return;
   }
 
   for (auto& result : *query_cache_results) {
     disk_cache::ScopedEntryPtr entry = std::move(result.entry);
     entry->Doom();
   }
 
-  UpdateCacheSize(base::Bind(callback, CACHE_STORAGE_OK));
+  UpdateCacheSize(base::BindOnce(std::move(callback), CACHE_STORAGE_OK));
 }
 
 void CacheStorageCache::KeysImpl(
     std::unique_ptr<ServiceWorkerFetchRequest> request,
     const CacheStorageCacheQueryParams& options,
-    const RequestsCallback& callback) {
+    RequestsCallback callback) {
   DCHECK_NE(BACKEND_UNINITIALIZED, backend_state_);
   if (backend_state_ != BACKEND_OPEN) {
-    callback.Run(CACHE_STORAGE_ERROR_STORAGE, std::unique_ptr<Requests>());
+    std::move(callback).Run(CACHE_STORAGE_ERROR_STORAGE,
+                            std::unique_ptr<Requests>());
     return;
   }
 
-  QueryCache(std::move(request), options, QueryCacheType::REQUESTS,
-             base::Bind(&CacheStorageCache::KeysDidQueryCache,
-                        weak_ptr_factory_.GetWeakPtr(), callback));
+  QueryCache(
+      std::move(request), options, QueryCacheType::REQUESTS,
+      base::BindOnce(&CacheStorageCache::KeysDidQueryCache,
+                     weak_ptr_factory_.GetWeakPtr(), std::move(callback)));
 }
 
 void CacheStorageCache::KeysDidQueryCache(
-    const RequestsCallback& callback,
+    RequestsCallback callback,
     CacheStorageError error,
     std::unique_ptr<QueryCacheResults> query_cache_results) {
   if (error != CACHE_STORAGE_OK) {
-    callback.Run(error, std::unique_ptr<Requests>());
+    std::move(callback).Run(error, std::unique_ptr<Requests>());
     return;
   }
 
   std::unique_ptr<Requests> out_requests = base::MakeUnique<Requests>();
   out_requests->reserve(query_cache_results->size());
   for (const auto& result : *query_cache_results)
     out_requests->push_back(*result.request);
 
-  callback.Run(CACHE_STORAGE_OK, std::move(out_requests));
+  std::move(callback).Run(CACHE_STORAGE_OK, std::move(out_requests));
 }
 
-void CacheStorageCache::CloseImpl(const base::Closure& callback) {
+void CacheStorageCache::CloseImpl(base::OnceClosure callback) {
   DCHECK_NE(BACKEND_CLOSED, backend_state_);
 
   backend_state_ = BACKEND_CLOSED;
   backend_.reset();
-  callback.Run();
+  std::move(callback).Run();
 }
 
-void CacheStorageCache::SizeImpl(const SizeCallback& callback) {
+void CacheStorageCache::SizeImpl(SizeCallback callback) {
   DCHECK_NE(BACKEND_UNINITIALIZED, backend_state_);
 
   int64_t size = backend_state_ == BACKEND_OPEN ? cache_size_ : 0;
-  base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
-                                                base::Bind(callback, size));
+  base::ThreadTaskRunnerHandle::Get()->PostTask(
+      FROM_HERE, base::BindOnce(std::move(callback), size));
 }
 
-void CacheStorageCache::GetSizeThenCloseDidGetSize(const SizeCallback& callback,
+void CacheStorageCache::GetSizeThenCloseDidGetSize(SizeCallback callback,
                                                    int64_t cache_size) {
-  CloseImpl(base::Bind(callback, cache_size));
+  CloseImpl(base::BindOnce(std::move(callback), cache_size));
 }
 
-void CacheStorageCache::CreateBackend(const ErrorCallback& callback) {
+void CacheStorageCache::CreateBackend(ErrorCallback callback) {
   DCHECK(!backend_);
 
   // Use APP_CACHE as opposed to DISK_CACHE to prevent cache eviction.
   net::CacheType cache_type = memory_only_ ? net::MEMORY_CACHE : net::APP_CACHE;
 
   std::unique_ptr<ScopedBackendPtr> backend_ptr(new ScopedBackendPtr());
 
   // Temporary pointer so that backend_ptr can be Pass()'d in Bind below.
   ScopedBackendPtr* backend = backend_ptr.get();
 
   net::CompletionCallback create_cache_callback =
-      base::Bind(&CacheStorageCache::CreateBackendDidCreate,
-                 weak_ptr_factory_.GetWeakPtr(), callback,
-                 base::Passed(std::move(backend_ptr)));
+      base::AdaptCallbackForRepeating(
+          base::BindOnce(&CacheStorageCache::CreateBackendDidCreate,
+                         weak_ptr_factory_.GetWeakPtr(), std::move(callback),
+                         base::Passed(std::move(backend_ptr))));
 
   // TODO(jkarlin): Use the cache task runner that ServiceWorkerCacheCore
   // has for disk caches.
   int rv = disk_cache::CreateCacheBackend(
       cache_type, net::CACHE_BACKEND_SIMPLE, path_, kMaxCacheBytes,
       false, /* force */
       BrowserThread::GetTaskRunnerForThread(BrowserThread::CACHE).get(), NULL,
       backend, create_cache_callback);
   if (rv != net::ERR_IO_PENDING)
     create_cache_callback.Run(rv);
 }
 
 void CacheStorageCache::CreateBackendDidCreate(
-    const CacheStorageCache::ErrorCallback& callback,
+    CacheStorageCache::ErrorCallback callback,
     std::unique_ptr<ScopedBackendPtr> backend_ptr,
     int rv) {
   if (rv != net::OK) {
-    callback.Run(CACHE_STORAGE_ERROR_STORAGE);
+    std::move(callback).Run(CACHE_STORAGE_ERROR_STORAGE);
     return;
   }
 
   backend_ = std::move(*backend_ptr);
-  callback.Run(CACHE_STORAGE_OK);
+  std::move(callback).Run(CACHE_STORAGE_OK);
 }
 
 void CacheStorageCache::InitBackend() {
   DCHECK_EQ(BACKEND_UNINITIALIZED, backend_state_);
   DCHECK(!initializing_);
   DCHECK(!scheduler_->ScheduledOperations());
   initializing_ = true;
 
-  scheduler_->ScheduleOperation(base::Bind(
+  scheduler_->ScheduleOperation(base::BindOnce(
       &CacheStorageCache::CreateBackend, weak_ptr_factory_.GetWeakPtr(),
-      base::Bind(
-          &CacheStorageCache::InitDidCreateBackend,
-          weak_ptr_factory_.GetWeakPtr(),
-          scheduler_->WrapCallbackToRunNext(base::Bind(&base::DoNothing)))));
+      base::BindOnce(&CacheStorageCache::InitDidCreateBackend,
+                     weak_ptr_factory_.GetWeakPtr(),
+                     scheduler_->WrapCallbackToRunNext(
+                         base::BindOnce(&base::DoNothing)))));
 }
 
 void CacheStorageCache::InitDidCreateBackend(
-    const base::Closure& callback,
+    base::OnceClosure callback,
     CacheStorageError cache_create_error) {
   if (cache_create_error != CACHE_STORAGE_OK) {
-    InitGotCacheSize(callback, cache_create_error, 0);
+    InitGotCacheSize(std::move(callback), cache_create_error, 0);
     return;
   }
 
-  int rv = backend_->CalculateSizeOfAllEntries(
-      base::Bind(&CacheStorageCache::InitGotCacheSize,
-                 weak_ptr_factory_.GetWeakPtr(), callback, cache_create_error));
+  net::CompletionCallback size_callback =
+      base::AdaptCallbackForRepeating(base::BindOnce(
+          &CacheStorageCache::InitGotCacheSize, weak_ptr_factory_.GetWeakPtr(),
+          std::move(callback), cache_create_error));
 
+  int rv = backend_->CalculateSizeOfAllEntries(size_callback);

[cmumford, 2017/06/21 19:07:56]

Don't you lose copy elision by converting to a local variable? Do you need to
std::move(size_callback)?

[jsbell, 2017/06/21 20:38:16]

Nope - because size_callback is a RepeatingClosure.

The subsequent std::move(size_callback) on line 1483 is unnecessary here (it
could just be `size_callback.Run(rv)`) but is harmless.

   if (rv != net::ERR_IO_PENDING)
-    InitGotCacheSize(callback, cache_create_error, rv);
+    std::move(size_callback).Run(rv);
 }
 
-void CacheStorageCache::InitGotCacheSize(const base::Closure& callback,
+void CacheStorageCache::InitGotCacheSize(base::OnceClosure callback,
                                          CacheStorageError cache_create_error,
                                          int cache_size) {
   // Now that we know the cache size either 1) the cache size should be unknown
   // (which is why the size was calculated), or 2) it must match the current
   // size. If the sizes aren't equal then there is a bug in how the cache size
   // is saved in the store's index.
   if (cache_size_ != CacheStorage::kSizeUnknown) {
     LOG_IF(ERROR, cache_size_ != cache_size)
         << "Cache size: " << cache_size
         << " does not match size from index: " << cache_size_;
     UMA_HISTOGRAM_COUNTS_10M("ServiceWorkerCache.IndexSizeDifference",
                              std::abs(cache_size_ - cache_size));
     // Disabled for crbug.com/681900.
     // DCHECK_EQ(cache_size_, cache_size);
   }
   cache_size_ = cache_size;
   initializing_ = false;
   backend_state_ = (cache_create_error == CACHE_STORAGE_OK && backend_ &&
                     backend_state_ == BACKEND_UNINITIALIZED)
                        ? BACKEND_OPEN
                        : BACKEND_CLOSED;
 
   UMA_HISTOGRAM_ENUMERATION("ServiceWorkerCache.InitBackendResult",
                             cache_create_error, CACHE_STORAGE_ERROR_LAST + 1);
 
   if (cache_observer_)
     cache_observer_->CacheSizeUpdated(this, cache_size_);
 
-  callback.Run();
+  std::move(callback).Run();
 }
 
 std::unique_ptr<storage::BlobDataHandle>
 CacheStorageCache::PopulateResponseBody(disk_cache::ScopedEntryPtr entry,
                                         ServiceWorkerResponse* response) {
   DCHECK(blob_storage_context_);
 
   // Create a blob with the response body data.
   response->blob_size = entry->GetDataSize(INDEX_RESPONSE_BODY);
   response->blob_uuid = base::GenerateGUID();
   storage::BlobDataBuilder blob_data(response->blob_uuid);
 
   disk_cache::Entry* temp_entry = entry.get();
   blob_data.AppendDiskCacheEntryWithSideData(
       new CacheStorageCacheDataHandle(CreateCacheHandle(), std::move(entry)),
       temp_entry, INDEX_RESPONSE_BODY, INDEX_SIDE_DATA);
   return blob_storage_context_->AddFinishedBlob(&blob_data);
 }
 
 std::unique_ptr<CacheStorageCacheHandle>
 CacheStorageCache::CreateCacheHandle() {
   return cache_storage_->CreateCacheHandle(this);
 }
 
 }  // namespace content