Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Issue 2947743002: Add support to pass the location of the analysis options file to plugins (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 6 months ago
Reviewers:
mfairhurst
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support to pass the location of the analysis options file to plugins R=mfairhurst@google.com Committed: https://github.com/dart-lang/sdk/commit/24996fbfe778a6ac9c91fe9a811f861586a02b1d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -83 lines) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 4 chunks +36 lines, -28 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/plugin_manager.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/src/plugin/plugin_manager_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/source/analysis_options_provider.dart View 2 chunks +11 lines, -2 lines 0 comments Download
M pkg/analyzer_plugin/doc/api.html View 7 chunks +17 lines, -11 lines 0 comments Download
M pkg/analyzer_plugin/lib/protocol/protocol_generated.dart View 10 chunks +40 lines, -12 lines 0 comments Download
M pkg/analyzer_plugin/test/integration/support/integration_test_methods.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer_plugin/test/integration/support/protocol_matchers.dart View 3 chunks +22 lines, -17 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/plugin_spec.html View 8 chunks +16 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 6 months ago (2017-06-19 21:37:06 UTC) #2
mfairhurst
LGTM
3 years, 6 months ago (2017-06-19 22:12:58 UTC) #3
Brian Wilkerson
3 years, 6 months ago (2017-06-20 14:41:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
24996fbfe778a6ac9c91fe9a811f861586a02b1d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698