Fix ParameterElementImpl.hasImplicitType for function-typed parameters.

Fix ParameterElementImpl.hasImplicitType for function-typed parameters.

UnlinkedParam.type serves a dual role: for ordinary parameters it is
the declared type; for function-typed parameters it is the declared
return type.  So to determine whether a parameter has an implicit type
it is not sufficient to check whether UnlinkedParam.type is `null`.
We also need to check whether the parameter is function-typed.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/e8131d6f1a4d75155e017c67bb7615d1ae87561b

[Paul Berry, 2017-06-19 19:47:12]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2017-06-19 19:50:08]

lgtm

[Paul Berry, 2017-06-19 20:13:57]

Description was changed from

==========
Fix ParameterElementImpl.hasImplicitType for function-typed parameters.

UnlinkedParam.type serves a dual role: for ordinary parameters it is
the declared type; for function-typed parameters it is the declared
return type.  So to determine whether a parameter has an implicit type
it is not sufficient to check whether UnlinkedParam.type is `null`.
We also need to check whether the parameter is function-typed.
==========

to

==========
Fix ParameterElementImpl.hasImplicitType for function-typed parameters.

UnlinkedParam.type serves a dual role: for ordinary parameters it is
the declared type; for function-typed parameters it is the declared
return type.  So to determine whether a parameter has an implicit type
it is not sufficient to check whether UnlinkedParam.type is `null`.
We also need to check whether the parameter is function-typed.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e8131d6f1a4d75155e017c67bb7615d1ae87561b
==========

[Paul Berry, 2017-06-19 20:13:58]

Committed patchset #1 (id:1) manually as
e8131d6f1a4d75155e017c67bb7615d1ae87561b (presubmit successful).

[scheglov, 2017-06-26 16:21:01]

scheglov@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-06-26 16:21:02]

LGTM