Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2947673002: Consider Contexts to be user objects for purposes of Obervatory's dominator analysis. (Closed)

Created:
3 years, 6 months ago by rmacnak
Modified:
3 years, 6 months ago
Reviewers:
cbernaschina
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Consider Contexts to be user objects for purposes of Obervatory's dominator analysis. User data in may be reachable only through a closure's environment, represented as a Context object. Note we still don't consider Functions to be user objects here, and so avoid blaming the size of compiled code against any user object. R=cbernaschina@google.com Committed: https://github.com/dart-lang/sdk/commit/1905d2bbe20e627a0f073271fd65d8fad2d67dd2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M runtime/vm/object_graph.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
3 years, 6 months ago (2017-06-19 18:17:45 UTC) #2
cbernaschina
On 2017/06/19 18:17:45, rmacnak wrote: lgtm
3 years, 6 months ago (2017-06-20 16:59:09 UTC) #3
rmacnak
3 years, 6 months ago (2017-06-20 23:59:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1905d2bbe20e627a0f073271fd65d8fad2d67dd2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698