Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: ios/chrome/browser/autocomplete/autocomplete_provider_client_impl.cc

Issue 2947643002: [ios] Enables the BuiltinProvider. (Closed)
Patch Set: Review Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/omnibox/browser/autocomplete_classifier.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/autocomplete/autocomplete_provider_client_impl.cc
diff --git a/ios/chrome/browser/autocomplete/autocomplete_provider_client_impl.cc b/ios/chrome/browser/autocomplete/autocomplete_provider_client_impl.cc
index 345b7a2d7a6309804c8efc78c290133eead9fca6..66c213b70887abdee87558f6774b3c99a5468d3d 100644
--- a/ios/chrome/browser/autocomplete/autocomplete_provider_client_impl.cc
+++ b/ios/chrome/browser/autocomplete/autocomplete_provider_client_impl.cc
@@ -119,14 +119,21 @@ AutocompleteProviderClientImpl::GetEmbedderRepresentationOfAboutScheme() {
}
std::vector<base::string16> AutocompleteProviderClientImpl::GetBuiltinURLs() {
- // iOS does not supports BuiltinProvider.
- return std::vector<base::string16>();
+ std::vector<std::string> chrome_builtins(
+ kChromeHostURLs, kChromeHostURLs + kNumberOfChromeHostURLs);
+ std::sort(chrome_builtins.begin(), chrome_builtins.end());
+
+ std::vector<base::string16> builtins;
+ for (auto& url : chrome_builtins) {
+ builtins.push_back(base::ASCIIToUTF16(url));
+ }
+ return builtins;
}
std::vector<base::string16>
AutocompleteProviderClientImpl::GetBuiltinsToProvideAsUserTypes() {
- // iOS does not supports BuiltinProvider.
- return std::vector<base::string16>();
+ return {base::ASCIIToUTF16(kChromeUIChromeURLsURL),
+ base::ASCIIToUTF16(kChromeUIVersionURL)};
}
bool AutocompleteProviderClientImpl::IsOffTheRecord() const {
« no previous file with comments | « components/omnibox/browser/autocomplete_classifier.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698